-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: add enum casting #9752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: add enum casting #9752
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * This file is part of CodeIgniter 4 framework. | ||
| * | ||
| * (c) CodeIgniter Foundation <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view | ||
| * the LICENSE file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace CodeIgniter\DataCaster\Cast; | ||
|
|
||
| use BackedEnum; | ||
| use CodeIgniter\DataCaster\Exceptions\CastException; | ||
| use ReflectionEnum; | ||
| use UnitEnum; | ||
|
|
||
| /** | ||
| * Class EnumCast | ||
| * | ||
| * Handles casting for PHP enums (both backed and unit enums) | ||
| * | ||
| * (PHP) [enum --> value/name] --> (DB driver) --> (DB column) int|string | ||
| * [ <-- value/name] <-- (DB driver) <-- (DB column) int|string | ||
| */ | ||
| class EnumCast extends BaseCast implements CastInterface | ||
| { | ||
| public static function get( | ||
| mixed $value, | ||
| array $params = [], | ||
| ?object $helper = null, | ||
| ): BackedEnum|UnitEnum { | ||
| if (! is_string($value) && ! is_int($value)) { | ||
| self::invalidTypeValueError($value); | ||
| } | ||
|
|
||
| $enumClass = $params[0] ?? null; | ||
|
|
||
| if ($enumClass === null) { | ||
| throw CastException::forMissingEnumClass(); | ||
| } | ||
|
|
||
| if (! enum_exists($enumClass)) { | ||
| throw CastException::forNotEnum($enumClass); | ||
| } | ||
|
|
||
| $reflection = new ReflectionEnum($enumClass); | ||
|
|
||
| // Unit enum | ||
| if (! $reflection->isBacked()) { | ||
| // Unit enum - match by name | ||
| foreach ($enumClass::cases() as $case) { | ||
| if ($case->name === $value) { | ||
| return $case; | ||
| } | ||
| } | ||
|
|
||
| throw CastException::forInvalidEnumCaseName($enumClass, $value); | ||
| } | ||
|
|
||
| // Backed enum - validate and cast the value to proper type | ||
| $backingType = $reflection->getBackingType(); | ||
|
|
||
| // Cast to proper type (int or string) | ||
| if ($backingType->getName() === 'int') { | ||
| $value = (int) $value; | ||
| } elseif ($backingType->getName() === 'string') { | ||
| $value = (string) $value; | ||
| } | ||
|
|
||
| $enum = $enumClass::tryFrom($value); | ||
|
|
||
| if ($enum === null) { | ||
| throw CastException::forInvalidEnumValue($enumClass, $value); | ||
| } | ||
|
|
||
| return $enum; | ||
| } | ||
|
|
||
| public static function set( | ||
| mixed $value, | ||
| array $params = [], | ||
| ?object $helper = null, | ||
| ): int|string { | ||
| if (! is_object($value) || ! enum_exists($value::class)) { | ||
| self::invalidTypeValueError($value); | ||
| } | ||
|
|
||
| // Get the expected enum class | ||
| $enumClass = $params[0] ?? null; | ||
|
|
||
| if ($enumClass === null) { | ||
| throw CastException::forMissingEnumClass(); | ||
| } | ||
|
|
||
| if (! enum_exists($enumClass)) { | ||
| throw CastException::forNotEnum($enumClass); | ||
| } | ||
|
|
||
| // Validate that the enum is of the expected type | ||
| if (! $value instanceof $enumClass) { | ||
| throw CastException::forInvalidEnumType($enumClass, $value::class); | ||
| } | ||
|
|
||
| $reflection = new ReflectionEnum($value::class); | ||
|
|
||
| // Backed enum - return the properly typed backing value | ||
| if ($reflection->isBacked()) { | ||
| /** @var BackedEnum $value */ | ||
| return $value->value; | ||
| } | ||
|
|
||
| // Unit enum - return the case name | ||
| /** @var UnitEnum $value */ | ||
| return $value->name; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * This file is part of CodeIgniter 4 framework. | ||
| * | ||
| * (c) CodeIgniter Foundation <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view | ||
| * the LICENSE file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace CodeIgniter\Entity\Cast; | ||
|
|
||
| use BackedEnum; | ||
| use CodeIgniter\Entity\Exceptions\CastException; | ||
| use ReflectionEnum; | ||
| use UnitEnum; | ||
|
|
||
| class EnumCast extends BaseCast | ||
| { | ||
| public static function get($value, array $params = []): BackedEnum|UnitEnum | ||
| { | ||
| $enumClass = $params[0] ?? null; | ||
|
|
||
| if ($enumClass === null) { | ||
| throw CastException::forMissingEnumClass(); | ||
| } | ||
|
|
||
| if (! enum_exists($enumClass)) { | ||
| throw CastException::forNotEnum($enumClass); | ||
| } | ||
|
|
||
| $reflection = new ReflectionEnum($enumClass); | ||
|
|
||
| // Backed enum - validate and cast the value to proper type | ||
| if ($reflection->isBacked()) { | ||
| $backingType = $reflection->getBackingType(); | ||
|
|
||
| // Cast to proper type (int or string) | ||
| if ($backingType->getName() === 'int') { | ||
| $value = (int) $value; | ||
| } elseif ($backingType->getName() === 'string') { | ||
| $value = (string) $value; | ||
| } | ||
|
|
||
| $enum = $enumClass::tryFrom($value); | ||
|
|
||
| if ($enum === null) { | ||
| throw CastException::forInvalidEnumValue($enumClass, $value); | ||
| } | ||
|
|
||
| return $enum; | ||
| } | ||
|
|
||
| // Unit enum - match by name | ||
| foreach ($enumClass::cases() as $case) { | ||
| if ($case->name === $value) { | ||
| return $case; | ||
| } | ||
| } | ||
|
|
||
| throw CastException::forInvalidEnumCaseName($enumClass, $value); | ||
| } | ||
|
|
||
| public static function set($value, array $params = []): int|string | ||
| { | ||
| // Get the expected enum class | ||
| $enumClass = $params[0] ?? null; | ||
|
|
||
| if ($enumClass === null) { | ||
| throw CastException::forMissingEnumClass(); | ||
| } | ||
|
|
||
| if (! enum_exists($enumClass)) { | ||
| throw CastException::forNotEnum($enumClass); | ||
| } | ||
|
|
||
| // If it's already an enum object, validate and extract its value | ||
| if (is_object($value) && enum_exists($value::class)) { | ||
| // Validate that the enum is of the expected type | ||
| if (! $value instanceof $enumClass) { | ||
| throw CastException::forInvalidEnumType($enumClass, $value::class); | ||
| } | ||
|
|
||
| $reflection = new ReflectionEnum($value::class); | ||
|
|
||
| // Backed enum - return the properly typed backing value | ||
| if ($reflection->isBacked()) { | ||
| /** @var BackedEnum $value */ | ||
| return $value->value; | ||
| } | ||
|
|
||
| // Unit enum - return the case name | ||
| /** @var UnitEnum $value */ | ||
| return $value->name; | ||
| } | ||
|
|
||
| $reflection = new ReflectionEnum($enumClass); | ||
|
|
||
| // Validate backed enum values | ||
| if ($reflection->isBacked()) { | ||
| $backingType = $reflection->getBackingType(); | ||
|
|
||
| // Cast to proper type (int or string) | ||
| if ($backingType->getName() === 'int') { | ||
| $value = (int) $value; | ||
| } elseif ($backingType->getName() === 'string') { | ||
| $value = (string) $value; | ||
| } | ||
|
|
||
| if ($enumClass::tryFrom($value) === null) { | ||
| throw CastException::forInvalidEnumValue($enumClass, $value); | ||
| } | ||
|
|
||
| return $value; | ||
| } | ||
|
|
||
| // Validate unit enum case names - must be a string | ||
| $value = (string) $value; | ||
|
|
||
| foreach ($enumClass::cases() as $case) { | ||
| if ($case->name === $value) { | ||
| return $value; | ||
| } | ||
| } | ||
|
|
||
| throw CastException::forInvalidEnumCaseName($enumClass, $value); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.