Skip to content

refactor: use superglobals service in the UserAgent class #9783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2025
Merged

refactor: use superglobals service in the UserAgent class #9783

merged 5 commits into from
Oct 31, 2025

Conversation

@michalsn
Copy link
Member

Description
This PR refactors the UserAgent class to use superglobals service.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the refactor Pull requests that refactor code label Oct 31, 2025
@michalsn michalsn merged commit 50116bb into codeigniter4:develop Oct 31, 2025
49 checks passed
@michalsn
Copy link
Member Author

Thank you @paulbalandan and @neznaika0

datamweb
datamweb reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+2 more reviewers

@datamweb datamweb datamweb left review comments

@neznaika0 neznaika0 neznaika0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michalsn @datamweb @neznaika0 @paulbalandan