-
Notifications
You must be signed in to change notification settings - Fork 24
[김동욱] Sprint 10 #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bladnoch
wants to merge
15
commits into
codeit-bootcamp-spring:김동욱
Choose a base branch
from
bladnoch:mission10
base: 김동욱
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[김동욱] Sprint 10 #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bladnoch
commented
Aug 24, 2025
+ Role 추가
+ 세션 만료 응답 추가
+ jwt, jwt로그인 구현 + 로그아웃 구현 + 토큰 상태관리 기능 추가
ssjf409
reviewed
Aug 27, 2025
| @Column(name = "username", nullable = false) | ||
| private String username; | ||
|
|
||
| @Column(name = "token_type", nullable = false, length = 16) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Enumerated로 추가해서 tokenType을 enum으로 관리하면 더 좋을거 같아요
Collaborator
|
동욱님 고생하셨습니다. 제가 딱히 더 코멘트 달만한게 없었습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.