-
Notifications
You must be signed in to change notification settings - Fork 16
[문은서] Sprint10 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 문은서
Are you sure you want to change the base?
[문은서] Sprint10 #145
Conversation
|
p1. 이번에도 현재 sprint10 내용 외에도 여러 이전 작업 내역들이 혼재되어 있습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JwtTokenProvider가 토큰 발급, 갱신, 유효성 검사 기능을 모두 포함하여 정확하게 구현되었습니다.
| ) | ||
| .logout(logout -> logout | ||
| .logoutUrl("/api/auth/logout") | ||
| .addLogoutHandler(jwtLogoutHandler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LogoutHandler이 제대로 등록 됐습니다
| ) | ||
| .formLogin(login -> login | ||
| .loginProcessingUrl("/api/auth/login") | ||
| .successHandler(jwtLoginSuccessHandler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LoginSuccessHandler이 제대로 등록 됐습니다
| @Override | ||
| public void onAuthenticationSuccess(HttpServletRequest request, HttpServletResponse response, | ||
| Authentication authentication) throws IOException, ServletException { | ||
| response.setContentType(MediaType.APPLICATION_JSON_VALUE); | ||
|
|
||
| if (authentication.getPrincipal() instanceof DiscodeitUserDetails userDetails) { | ||
| UserDto userDto = userDetails.getUserDto(); | ||
| Map<String, Object> claims = Map.of("roles", userDetails.getAuthorities()); | ||
| String subject = userDto.email(); | ||
|
|
||
| String accessToken = jwtTokenProvider.generateAccessToken(claims, subject); | ||
| String refreshToken = jwtTokenProvider.generateRefreshToken(claims, subject); | ||
|
|
||
| Cookie refreshTokenCookie = new Cookie("REFRESH_TOKEN", refreshToken); | ||
| refreshTokenCookie.setHttpOnly(true); | ||
| refreshTokenCookie.setPath("/"); | ||
| refreshTokenCookie.setMaxAge(7*24*60*60); | ||
| response.addCookie(refreshTokenCookie); | ||
|
|
||
| JwtDto jwtDto = new JwtDto(userDto, accessToken, refreshToken); | ||
|
|
||
| response.setStatus(HttpServletResponse.SC_OK); | ||
| response.setContentType(MediaType.APPLICATION_JSON_VALUE); | ||
| response.setCharacterEncoding("UTF-8"); | ||
| response.getWriter().write(objectMapper.writeValueAsString(jwtDto)); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
응답 쿠키에 리프레시 토큰, 응답 Body에 엑세스 토큰을 잘 저장합니다.
| private Map<String, Object> verifyJws(HttpServletRequest request) { | ||
| String authorization = request.getHeader("Authorization"); | ||
| if (authorization == null || !authorization.startsWith("Bearer ")) { | ||
| throw new RuntimeException("JWT 토큰이 존재하지 않습니다."); | ||
| } | ||
| String jws = authorization.replace("Bearer ",""); | ||
| boolean isValid = jwtTokenProvider.validateToken(jws); | ||
| if (!isValid) { | ||
| throw new RuntimeException("유효하지 않은 JWT 토큰입니다."); | ||
| } | ||
| return jwtTokenProvider.getClaims(jws); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bearer 식별 처리 정상
| JwtDto jwtDto = authService.reissueToken(refreshToken); | ||
|
|
||
| String newRefreshToken = jwtDto.getRefreshToken(); | ||
| Cookie cookie = new Cookie("REFRESH_TOKEN", newRefreshToken); | ||
| cookie.setHttpOnly(true); | ||
| cookie.setSecure(true); | ||
| cookie.setPath("/"); | ||
| cookie.setMaxAge(7 * 24 * 60 * 60); // 7 days | ||
| response.addCookie(cookie); | ||
| return ResponseEntity.ok(jwtDto); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service 계층으로 빼는게 더 좋을 것 같습니다
요구사항
기본
JWT 컴포넌트 구현
리팩토링 - 로그인
AuthenticationSuccessHandler 컴포넌트를 대체하세요.
인증 성공 시 JwtProvider를 활용해 토큰을 발급하세요.
200 JwtDto로 응답합니다.
JWT 인증 필터 구현
요청 당 한번만 실행되도록 OncePerRequestFilter를 상속하세요.
요청 헤더(Authorization)에 Bearer 토큰이 포함된 경우에만 인증을 시도하세요.
JwtProvider를 통해 엑세스 토큰의 유효성을 검사하세요.
유효한 토큰인 경우 UsernamePasswordAuthenticationToken 객체를 활용해 인증 완료 처리하세요.
리프레시 토큰을 활용한 엑세스 토큰 재발급
리프레시 토큰을 활용해 엑세스 토큰을 재발급하는 API를 구현하세요.
리프레시 토큰 Rotation을 통해 보안을 강화하세요.
토큰 재발급 API로 대체할 수 있는 컴포넌트를 모두 삭제하세요.
RememberMe
리팩토링 - 로그아웃
심화
주요 변경사항
스크린샷
멘토에게