-
Notifications
You must be signed in to change notification settings - Fork 63
enabled arrow icons to jump to previous and next lessons #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 20 commits
6b8794c
7798eb3
d3758f2
0667163
e3be024
bfc44b7
89831ea
e84f72b
caeb0bc
60f6141
5fe9484
52958ef
feb7744
ef0f7d5
e91ae03
d9ad958
f524ec9
28ddb49
4126829
65c6403
f5acd63
c9c3956
5bde57b
154b746
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import { TestBed } from '@angular/core/testing'; | ||
|
||
import { MenuRouteService } from './menu-route.service'; | ||
import { ActivatedRoute } from '@angular/router'; | ||
import { MENU_ROUTES, MenuRoutes } from '../../common'; | ||
|
||
describe('MenuRouteService', () => { | ||
const menuRoutes: MenuRoutes = [ | ||
{ | ||
path: 'previouslesson', | ||
prod: true | ||
}, | ||
{ | ||
path: 'currentlesson', | ||
prod: true | ||
}, | ||
{ | ||
path: 'nextlesson', | ||
prod: true | ||
} | ||
]; | ||
|
||
const activatedRouteStub = { | ||
snapshot: { | ||
pathFromRoot: [ | ||
{ | ||
routeConfig: menuRoutes[1] | ||
} | ||
] | ||
} | ||
} as ActivatedRoute; | ||
|
||
beforeEach(() => | ||
TestBed.configureTestingModule({ | ||
providers: [{ provide: MENU_ROUTES, useValue: menuRoutes }] | ||
}) | ||
); | ||
|
||
it('should be created', () => { | ||
const service: MenuRouteService = TestBed.inject(MenuRouteService); | ||
expect(service).toBeTruthy(); | ||
}); | ||
|
||
it('getPreviousLink should return previouslesson', () => { | ||
const service: MenuRouteService = TestBed.inject(MenuRouteService); | ||
const previousLink = service.getPreviousLink(activatedRouteStub); | ||
expect(previousLink).toEqual(menuRoutes[0].path); | ||
}); | ||
|
||
it('getNextLink should return nextlesson', () => { | ||
const service: MenuRouteService = TestBed.inject(MenuRouteService); | ||
const nextLink = service.getNextLink(activatedRouteStub); | ||
expect(nextLink).toEqual(menuRoutes[2].path); | ||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import { Injectable, Inject } from '@angular/core'; | ||
import { ActivatedRoute, Router } from '@angular/router'; | ||
import { MENU_ROUTES, MenuRoute } from '../../common'; | ||
|
||
@Injectable({ | ||
providedIn: 'root' | ||
}) | ||
export class MenuRouteService { | ||
constructor(@Inject(MENU_ROUTES) private readonly menuRoutes) {} | ||
|
||
getPreviousLink(activeRoute: ActivatedRoute): string { | ||
const index = this.getCurrentIndex(activeRoute); | ||
if (index > 0) { | ||
return this.menuRoutes[index - 1].path; | ||
} | ||
return ''; | ||
} | ||
|
||
getNextLink(activeRoute: ActivatedRoute): string { | ||
const index = this.getCurrentIndex(activeRoute); | ||
if (index < this.menuRoutes.length - 1) { | ||
NothingEverHappens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return this.menuRoutes[index + 1].path; | ||
} | ||
return ''; | ||
} | ||
|
||
private getCurrentIndex(activeRoute: ActivatedRoute) { | ||
// TODO: inject ActivatedRoute but figure out a way to fix snapshot update issue | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be awesome for this comment to be more detailed so that next person who sees this knows what the issue is and how to reproduce |
||
const config = activeRoute.snapshot.pathFromRoot | ||
.map(a => a.routeConfig) | ||
.find(r => r && (r as MenuRoute).prod); | ||
if (config == null) { | ||
return -1; | ||
} | ||
const index = this.menuRoutes.findIndex(c => c.path === config.path); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need for an intermediate var, just return? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ☝️ |
||
return index; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import { Component, Input, OnInit } from '@angular/core'; | ||
import { SlidesDeckComponent } from '@codelab/slides/src/lib/deck/deck.component'; | ||
import { MenuRouteService } from '../../../codelabs/angular/menu-route.service'; | ||
import { ActivatedRoute } from '@angular/router'; | ||
|
||
@Component({ | ||
selector: 'codelab-closing-slide', | ||
|
@@ -10,7 +13,19 @@ export class CodelabClosingSlideComponent implements OnInit { | |
@Input() body: String; | ||
@Input() footer: String; | ||
|
||
constructor() {} | ||
constructor( | ||
private readonly activeRoute: ActivatedRoute, | ||
private readonly menuRouteService: MenuRouteService, | ||
private readonly presentation: SlidesDeckComponent | ||
) { | ||
if (this.presentation != null) { | ||
let nextLink = this.menuRouteService.getNextLink(this.activeRoute); | ||
if (nextLink) { | ||
nextLink = '../../' + nextLink; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should also prob be a TODO here to make it more generic There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should also prob be a TODO here to make it more generic |
||
} | ||
this.presentation.setNext(nextLink); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Drop empty ngOnInit while you're here? |
||
} | ||
} | ||
|
||
ngOnInit() {} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import { Component, Input } from '@angular/core'; | ||
import { SlidesDeckComponent } from '@codelab/slides/src/lib/deck/deck.component'; | ||
import { MenuRouteService } from '../../../codelabs/angular/menu-route.service'; | ||
import { ActivatedRoute } from '@angular/router'; | ||
|
||
@Component({ | ||
selector: 'codelab-title-slide', | ||
|
@@ -9,4 +12,20 @@ export class TitleSlideComponent { | |
@Input() title: string; | ||
@Input() description: string; | ||
@Input() prereqs: string; | ||
|
||
constructor( | ||
private readonly activeRoute: ActivatedRoute, | ||
private readonly menuRouteService: MenuRouteService, | ||
private readonly presentation: SlidesDeckComponent | ||
) { | ||
if (this.presentation != null) { | ||
sunilj74 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
let previousLink = this.menuRouteService.getPreviousLink( | ||
this.activeRoute | ||
); | ||
if (previousLink) { | ||
previousLink = '../../' + previousLink; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We always do this for both next and previous link, I think this should move in |
||
} | ||
this.presentation.setPrevious(previousLink); | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ import { | |
TemplateRef | ||
} from '@angular/core'; | ||
|
||
import { ActivatedRoute } from '@angular/router'; | ||
import { ActivatedRoute, Router } from '@angular/router'; | ||
|
||
@Component({ | ||
selector: 'slide-deck', | ||
|
@@ -27,9 +27,12 @@ export class SlidesDeckComponent { | |
@Output() slideAdded = new EventEmitter<{ index: number; id: string }>(); | ||
@HostBinding('class.has-milestone') hasMilestone = false; | ||
private milestone = ''; | ||
private previousLink: string; | ||
private nextLink: string; | ||
|
||
constructor( | ||
private readonly cdr: ChangeDetectorRef, | ||
private readonly router: Router, | ||
@Optional() private readonly route: ActivatedRoute | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: let's call (active|activated)Route to be consistent |
||
) { | ||
if (route) { | ||
|
@@ -51,18 +54,34 @@ export class SlidesDeckComponent { | |
} | ||
|
||
nextSlide() { | ||
this.goToSlide(this.activeSlideIndex + 1); | ||
if (this.activeSlideIndex + 1 < this.slides.length) { | ||
this.goToSlide(this.activeSlideIndex + 1); | ||
} else if (this.nextLink) { | ||
this.router.navigate([this.nextLink], { relativeTo: this.route }); | ||
} | ||
} | ||
|
||
previousSlide() { | ||
this.goToSlide(this.activeSlideIndex - 1); | ||
if (this.activeSlideIndex > 0) { | ||
this.goToSlide(this.activeSlideIndex - 1); | ||
} else if (this.previousLink) { | ||
this.router.navigate([this.previousLink], { relativeTo: this.route }); | ||
} | ||
} | ||
|
||
canGoNext(): boolean { | ||
return this.activeSlideIndex + 1 < this.slides.length; | ||
return this.activeSlideIndex + 1 < this.slides.length || !!this.nextLink; | ||
} | ||
|
||
canGoPrevious(): boolean { | ||
return this.activeSlideIndex > 0; | ||
return this.activeSlideIndex > 0 || !!this.previousLink; | ||
} | ||
|
||
public setPrevious(previousLink) { | ||
this.previousLink = previousLink; | ||
} | ||
|
||
public setNext(nextLink) { | ||
this.nextLink = nextLink; | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.