-
Notifications
You must be signed in to change notification settings - Fork 63
enabled arrow icons to jump to previous and next lessons #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 9 commits
6b8794c
7798eb3
d3758f2
0667163
e3be024
bfc44b7
89831ea
e84f72b
caeb0bc
60f6141
5fe9484
52958ef
feb7744
ef0f7d5
e91ae03
d9ad958
f524ec9
28ddb49
4126829
65c6403
f5acd63
c9c3956
5bde57b
154b746
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,54 @@ | ||
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; | ||
|
||
import { CodelabClosingSlideComponent } from './codelab-closing-slide.component'; | ||
import { Router } from '@angular/router'; | ||
import { SlidesDeckComponent } from '@codelab/slides/src/lib/deck/deck.component'; | ||
import { MENU_ROUTES, MenuRoutes } from '../../../common'; | ||
|
||
describe('CodelabClosingSlideComponent', () => { | ||
let component: CodelabClosingSlideComponent; | ||
let fixture: ComponentFixture<CodelabClosingSlideComponent>; | ||
const routerStub = { | ||
url: '/ngtest/currentlesson' | ||
}; | ||
|
||
const slidesDeckComponentStub = { | ||
previousLink: '', | ||
nextLink: '', | ||
|
||
setPrevious(link) { | ||
this.previousLink = link; | ||
}, | ||
|
||
setNext(link) { | ||
this.nextLink = link; | ||
} | ||
}; | ||
|
||
const menuRoutes: MenuRoutes = [ | ||
{ | ||
path: 'previouslesson' | ||
}, | ||
{ | ||
path: 'currentlesson' | ||
}, | ||
{ | ||
path: 'nextlesson' | ||
} | ||
]; | ||
|
||
beforeEach(async(() => { | ||
TestBed.configureTestingModule({ | ||
providers: [ | ||
{ provide: Router, useValue: routerStub }, | ||
{ provide: SlidesDeckComponent, useFactory: () => slidesDeckComponentStub }, | ||
{ provide: MENU_ROUTES, useValue: menuRoutes } | ||
], | ||
declarations: [CodelabClosingSlideComponent] | ||
}).compileComponents(); | ||
})); | ||
|
||
beforeEach(() => { | ||
spyOn(slidesDeckComponentStub, 'setNext'); | ||
fixture = TestBed.createComponent(CodelabClosingSlideComponent); | ||
component = fixture.componentInstance; | ||
fixture.detectChanges(); | ||
|
@@ -21,4 +57,8 @@ describe('CodelabClosingSlideComponent', () => { | |
it('should create', () => { | ||
expect(component).toBeTruthy(); | ||
}); | ||
|
||
it('should call setNextLink', () => { | ||
expect(slidesDeckComponentStub.setNext).toHaveBeenCalled(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we verify that it has been called with the proper argument? |
||
}); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import { Component, Input, OnInit } from '@angular/core'; | ||
import { Component, Input, OnInit, Inject, Optional } from '@angular/core'; | ||
import { SlidesDeckComponent } from '@codelab/slides/src/lib/deck/deck.component'; | ||
import { MENU_ROUTES } from '../../../common'; | ||
import { Router } from '@angular/router'; | ||
|
||
@Component({ | ||
selector: 'codelab-closing-slide', | ||
|
@@ -10,7 +13,32 @@ export class CodelabClosingSlideComponent implements OnInit { | |
@Input() body: String; | ||
@Input() footer: String; | ||
|
||
constructor() {} | ||
constructor( | ||
private readonly router: Router, | ||
private readonly presentation: SlidesDeckComponent, | ||
@Optional() @Inject(MENU_ROUTES) readonly menuRoutes | ||
) { | ||
if (this.menuRoutes != null) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At which point would menuRoutes be null? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ☝️ |
||
this.setupPreviousNext(); | ||
} | ||
} | ||
|
||
private setupPreviousNext() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This name seems outdated |
||
let nextLink = ''; | ||
const allRoutes = this.menuRoutes.map(p => p.path); | ||
let currentUrl = this.router.url; | ||
if (currentUrl.startsWith('/')) { | ||
currentUrl = currentUrl.substr(1); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code looks very complicated, what exactly is happening here? |
||
const urlPaths = currentUrl.split('/'); | ||
if (urlPaths.length > 1) { | ||
const idx = allRoutes.indexOf(urlPaths[1]); | ||
if (idx < allRoutes.length - 1) { | ||
nextLink = `/${urlPaths[0]}/${allRoutes[idx + 1]}`; | ||
} | ||
} | ||
this.presentation.setNext(nextLink); | ||
} | ||
|
||
ngOnInit() {} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,59 @@ | ||
import { async, ComponentFixture, TestBed } from '@angular/core/testing'; | ||
import { RouterTestingModule } from '@angular/router/testing'; | ||
import { By } from '@angular/platform-browser'; | ||
|
||
import { TitleSlideComponent } from './title-slide.component'; | ||
import { CodelabRippleAnimationComponent } from './ripple-animation/codelab-ripple-animation.component'; | ||
import { MenuRoutes, MENU_ROUTES } from '../../../common'; | ||
import { Router } from '@angular/router'; | ||
import { SlidesDeckComponent } from '@codelab/slides/src/lib/deck/deck.component'; | ||
|
||
describe('TitleSlideComponent', () => { | ||
let component: TitleSlideComponent; | ||
let fixture: ComponentFixture<TitleSlideComponent>; | ||
const routerStub = { | ||
url: '/ngtest/currentlesson' | ||
}; | ||
|
||
const slidesDeckComponentStub = { | ||
previousLink: '', | ||
nextLink: '', | ||
|
||
setPrevious(link) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just do setPrevious: createSpy(...) |
||
this.previousLink = link; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happened to the spies? |
||
}, | ||
|
||
setNext(link) { | ||
this.nextLink = link; | ||
} | ||
}; | ||
|
||
const menuRoutes: MenuRoutes = [ | ||
{ | ||
path: 'previouslesson' | ||
}, | ||
{ | ||
path: 'currentlesson' | ||
}, | ||
{ | ||
path: 'nextlesson' | ||
} | ||
]; | ||
|
||
beforeEach(async(() => { | ||
TestBed.configureTestingModule({ | ||
providers: [ | ||
{ provide: Router, useValue: routerStub }, | ||
{ provide: SlidesDeckComponent, useFactory: () => slidesDeckComponentStub }, | ||
{ provide: MENU_ROUTES, useValue: menuRoutes } | ||
], | ||
imports: [RouterTestingModule], | ||
declarations: [CodelabRippleAnimationComponent, TitleSlideComponent] | ||
}).compileComponents(); | ||
})); | ||
|
||
beforeEach(() => { | ||
spyOn(slidesDeckComponentStub, 'setPrevious'); | ||
fixture = TestBed.createComponent(TitleSlideComponent); | ||
component = fixture.componentInstance; | ||
fixture.detectChanges(); | ||
|
@@ -24,6 +63,10 @@ describe('TitleSlideComponent', () => { | |
expect(component).toBeTruthy(); | ||
}); | ||
|
||
it('should call setPrevious', () => { | ||
expect(slidesDeckComponentStub.setPrevious).toHaveBeenCalled(); | ||
}); | ||
|
||
it('should render a title', () => { | ||
component.title = 'awesome title'; | ||
fixture.detectChanges(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ import { | |
TemplateRef | ||
} from '@angular/core'; | ||
|
||
import { ActivatedRoute } from '@angular/router'; | ||
import { ActivatedRoute, Router } from '@angular/router'; | ||
|
||
@Component({ | ||
selector: 'slide-deck', | ||
|
@@ -27,9 +27,12 @@ export class SlidesDeckComponent { | |
@Output() slideAdded = new EventEmitter<{ index: number; id: string }>(); | ||
@HostBinding('class.has-milestone') hasMilestone = false; | ||
private milestone = ''; | ||
private previousLink: string; | ||
private nextLink: string; | ||
|
||
constructor( | ||
private readonly cdr: ChangeDetectorRef, | ||
private readonly router: Router, | ||
@Optional() private readonly route: ActivatedRoute | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: let's call (active|activated)Route to be consistent |
||
) { | ||
if (route) { | ||
|
@@ -51,18 +54,34 @@ export class SlidesDeckComponent { | |
} | ||
|
||
nextSlide() { | ||
this.goToSlide(this.activeSlideIndex + 1); | ||
if (this.activeSlideIndex + 1 < this.slides.length) { | ||
this.goToSlide(this.activeSlideIndex + 1); | ||
} else if (this.nextLink) { | ||
this.router.navigateByUrl(this.nextLink); | ||
} | ||
} | ||
|
||
previousSlide() { | ||
this.goToSlide(this.activeSlideIndex - 1); | ||
if (this.activeSlideIndex > 0) { | ||
this.goToSlide(this.activeSlideIndex - 1); | ||
} else if (this.previousLink) { | ||
this.router.navigateByUrl(this.previousLink); | ||
} | ||
} | ||
|
||
canGoNext(): boolean { | ||
return this.activeSlideIndex + 1 < this.slides.length; | ||
return this.activeSlideIndex + 1 < this.slides.length || !!this.nextLink; | ||
} | ||
|
||
canGoPrevious(): boolean { | ||
return this.activeSlideIndex > 0; | ||
return this.activeSlideIndex > 0 || !!this.previousLink; | ||
} | ||
|
||
public setPrevious(previousLink) { | ||
this.previousLink = previousLink; | ||
} | ||
|
||
public setNext(nextLink) { | ||
this.nextLink = nextLink; | ||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.