Fix unnecessary focus change transactions

marijnh · marijnh · commit dcd251c2ef05 · 2025-04-24T08:58:33.000+02:00
FIX: Fix an issue that caused unnecessary transactions on focus change. See https://discuss.codemirror.net/t/bug-of-focuschangetransaction-in-view-input-ts/9161
diff --git a/src/input.ts b/src/input.ts
@@ -808,7 +808,7 @@ export function focusChangeTransaction(state: EditorState, focus: boolean) {
     let effect = getEffect(state, focus)
     if (effect) effects.push(effect)
   }
-  return effects ? state.update({effects, annotations: isFocusChange.of(true)}) : null
+  return effects.length ? state.update({effects, annotations: isFocusChange.of(true)}) : null
 }
 
 function updateForFocusChange(view: EditorView) {

Original file line number	Diff line number	Diff line change
`@@ -808,7 +808,7 @@ export function focusChangeTransaction(state: EditorState, focus: boolean) {`
`808`	`808`	`let effect = getEffect(state, focus)`
`809`	`809`	`if (effect) effects.push(effect)`
`810`	`810`	`}`
`811`		`- return effects ? state.update({effects, annotations: isFocusChange.of(true)}) : null`
	`811`	`+ return effects.length ? state.update({effects, annotations: isFocusChange.of(true)}) : null`
`812`	`812`	`}`
`813`	`813`
`814`	`814`	`function updateForFocusChange(view: EditorView) {`