Resolve @self in queue commands to avoid simple_expansion prompts#31
Merged
Resolve @self in queue commands to avoid simple_expansion prompts#31
Conversation
Member
Author
|
Q: does |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@selfkeyword thatcodemob queueresolves internally to the current mob name viaCurrentMobName()/removeand/dropslash commands to usecodemob queue remove @selfinstead ofcodemob queue remove "$CODEMOB_MOB"simple_expansionpermission prompt since the command is now a plain literal string with no variable expansionCloses #29
Test plan
/dropfrom inside a mob - should queue remove without permission prompt/removeand select the current mob - same behaviorcodemob queue remove @selfmanually from inside a mob - resolves correctlycodemob queue remove @selfoutside a mob - errors with "@self: not inside a mob"codemob initand verify regenerated slash commands use@self