You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Fix SpotBugs FE_FLOATING_POINT_EQUALITY warnings
Fixed floating point equality checks by replacing `==` and `!=` with `Float.compare` and `Double.compare` or `isZero` checks across multiple files.
Updated `generate-quality-report.py` to enforce this rule in CI.
Fixed files:
- CodenameOne/src/com/codename1/ui/geom/GeneralPath.java
- CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java
- CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java
- CodenameOne/src/com/codename1/charts/models/XYSeries.java
- CodenameOne/src/com/codename1/charts/models/XYValueSeries.java
- CodenameOne/src/com/codename1/location/Location.java
- CodenameOne/src/com/codename1/ui/Command.java
- CodenameOne/src/com/codename1/ui/Stroke.java
- CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java
- CodenameOne/src/com/codename1/ui/plaf/Border.java
* Fix SpotBugs FE_FLOATING_POINT_EQUALITY warnings
Fixed floating point equality checks by replacing `==` and `!=` with `Float.compare` and `Double.compare` or `isZero` checks across multiple files.
Updated `generate-quality-report.py` to enforce this rule in CI.
Fixed files:
- CodenameOne/src/com/codename1/ui/geom/GeneralPath.java
- CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java
- CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java
- CodenameOne/src/com/codename1/charts/models/XYSeries.java
- CodenameOne/src/com/codename1/charts/models/XYValueSeries.java
- CodenameOne/src/com/codename1/location/Location.java
- CodenameOne/src/com/codename1/ui/Command.java
- CodenameOne/src/com/codename1/ui/Stroke.java
- CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java
- CodenameOne/src/com/codename1/ui/plaf/Border.java
* Fix SpotBugs FE_FLOATING_POINT_EQUALITY warnings
Refactored to use `com.codename1.util.MathUtil.compare` for floating point comparisons to avoid using `Float.compare` and `Double.compare` which are not available in CLDC 1.1.
Added `compare` methods to `com.codename1.util.MathUtil`.
Fixed `FE_FLOATING_POINT_EQUALITY` warnings in:
- CodenameOne/src/com/codename1/ui/geom/GeneralPath.java
- CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java
- CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java
- CodenameOne/src/com/codename1/charts/models/XYSeries.java
- CodenameOne/src/com/codename1/charts/models/XYValueSeries.java
- CodenameOne/src/com/codename1/location/Location.java
- CodenameOne/src/com/codename1/ui/Command.java
- CodenameOne/src/com/codename1/ui/Stroke.java
- CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java
- CodenameOne/src/com/codename1/ui/plaf/Border.java
Updated `generate-quality-report.py` to enforce this rule in CI.
---------
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
0 commit comments