Fix SpotBugs FE_FLOATING_POINT_EQUALITY warnings

google-labs-jules[bot] · google-labs-jules[bot] · commit 90cb66ebfc18 · 2025-12-26T05:27:01.000Z
Fixed floating point equality checks by replacing `==` and `!=` with `Float.compare` and `Double.compare` or `isZero` checks across multiple files.
Updated `generate-quality-report.py` to enforce this rule in CI.
Fixed files:
- CodenameOne/src/com/codename1/ui/geom/GeneralPath.java
- CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java
- CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java
- CodenameOne/src/com/codename1/charts/models/XYSeries.java
- CodenameOne/src/com/codename1/charts/models/XYValueSeries.java
- CodenameOne/src/com/codename1/location/Location.java
- CodenameOne/src/com/codename1/ui/Command.java
- CodenameOne/src/com/codename1/ui/Stroke.java
- CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java
- CodenameOne/src/com/codename1/ui/plaf/Border.java
diff --git a/.github/scripts/generate-quality-report.py b/.github/scripts/generate-quality-report.py
@@ -766,7 +766,8 @@ def main() -> None:
             "EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS",
             "IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD",
             "RpC_REPEATED_CONDITIONAL_TEST",
-            "ES_COMPARING_PARAMETER_STRING_WITH_EQ"
+            "ES_COMPARING_PARAMETER_STRING_WITH_EQ",
+            "FE_FLOATING_POINT_EQUALITY"
         }
         violations = [
             f for f in spotbugs.findings
diff --git a/CodenameOne/src/com/codename1/charts/models/XYSeries.java b/CodenameOne/src/com/codename1/charts/models/XYSeries.java
@@ -188,7 +188,7 @@ public void remove(int index) {
         XYEntry<Double, Double> removedEntry = mXY.removeByIndex(index);
         double removedX = removedEntry.getKey();
         double removedY = removedEntry.getValue();
-        if (removedX == mMinX || removedX == mMaxX || removedY == mMinY || removedY == mMaxY) {
+        if (Double.compare(removedX, mMinX) == 0 || Double.compare(removedX, mMaxX) == 0 || Double.compare(removedY, mMinY) == 0 || Double.compare(removedY, mMaxY) == 0) {
             initRange();
         }
     }
diff --git a/CodenameOne/src/com/codename1/charts/models/XYValueSeries.java b/CodenameOne/src/com/codename1/charts/models/XYValueSeries.java
@@ -94,7 +94,7 @@ public void add(double x, double y) {
     public void remove(int index) {
         super.remove(index);
         double removedValue = mValue.remove(index);
-        if (removedValue == mMinValue || removedValue == mMaxValue) {
+        if (Double.compare(removedValue, mMinValue) == 0 || Double.compare(removedValue, mMaxValue) == 0) {
             initRange();
         }
     }
diff --git a/CodenameOne/src/com/codename1/location/Location.java b/CodenameOne/src/com/codename1/location/Location.java
@@ -294,7 +294,7 @@ public int compare(Location o1, Location o2) {
      */
     boolean equalsLatLng(Location l) {
 
-        return l != null && l.latitude == latitude && l.longitude == longitude;
+        return l != null && Double.compare(l.latitude, latitude) == 0 && Double.compare(l.longitude, longitude) == 0;
 
     }
 }
diff --git a/CodenameOne/src/com/codename1/ui/Command.java b/CodenameOne/src/com/codename1/ui/Command.java
@@ -275,12 +275,12 @@ public boolean equals(Object obj) {
         if (((Command) obj).command == null) {
             return obj.getClass() == getClass() && command == null &&
                     ((Command) obj).icon == icon && ((Command) obj).commandId == commandId &&
-                    ((Command) obj).materialIcon == materialIcon && ((Command) obj).materialIconSize == materialIconSize &&
+                    ((Command) obj).materialIcon == materialIcon && Float.compare(((Command) obj).materialIconSize, materialIconSize) == 0 &&
                     (Objects.equals(clientProperties, ((Command) obj).clientProperties));
         } else {
             return obj.getClass() == getClass() && ((Command) obj).command.equals(command) &&
                     ((Command) obj).icon == icon && ((Command) obj).commandId == commandId &&
-                    ((Command) obj).materialIcon == materialIcon && ((Command) obj).materialIconSize == materialIconSize &&
+                    ((Command) obj).materialIcon == materialIcon && Float.compare(((Command) obj).materialIconSize, materialIconSize) == 0 &&
                     (Objects.equals(clientProperties, ((Command) obj).clientProperties));
         }
     }
diff --git a/CodenameOne/src/com/codename1/ui/Stroke.java b/CodenameOne/src/com/codename1/ui/Stroke.java
@@ -227,7 +227,7 @@ public void setMiterLimit(float miterLimit) {
     public boolean equals(Object obj) {
         if (obj instanceof Stroke) {
             Stroke s = (Stroke) obj;
-            return (s.miterLimit == miterLimit && s.capStyle == capStyle && s.joinStyle == joinStyle && s.lineWidth == lineWidth);
+            return (Float.compare(s.miterLimit, miterLimit) == 0 && s.capStyle == capStyle && s.joinStyle == joinStyle && Float.compare(s.lineWidth, lineWidth) == 0);
         }
         return false;
     }
diff --git a/CodenameOne/src/com/codename1/ui/geom/GeneralPath.java b/CodenameOne/src/com/codename1/ui/geom/GeneralPath.java
@@ -2224,7 +2224,7 @@ private static float[] intersectLineWithRectAsHash(float x1, float y1, float x2,
                 float minX = Math.min(x1, x2);
                 float maxX = Math.max(x1, x2);
                 int i = 0;
-                if (dx == 0) {
+                if (isZero(dx)) {
                     if (ry1 > minY && ry1 < maxY) {
                         num++;
                         x[i++] = ry1;
@@ -2255,7 +2255,7 @@ private static float[] intersectLineWithRectAsHash(float x1, float y1, float x2,
                     out[8] = num;
 
 
-                } else if (dy == 0) {
+                } else if (isZero(dy)) {
                     if (rx1 > minX && rx1 < maxX) {
                         num++;
                         x[i++] = rx1;
@@ -2344,8 +2344,8 @@ public static int solveQuad(double[] eqn, double[] res) {
             double b = eqn[1];
             double c = eqn[0];
             int rc = 0;
-            if (a == 0.0) {
-                if (b == 0.0) {
+            if (isZero(a)) {
+                if (isZero(b)) {
                     return -1;
                 }
                 res[rc++] = -c / b;
@@ -2358,7 +2358,7 @@ public static int solveQuad(double[] eqn, double[] res) {
                 d = Math.sqrt(d);
                 res[rc++] = (-b + d) / (a * 2.0);
                 // d != 0.0
-                if (d != 0.0) {
+                if (!isZero(d)) {
                     res[rc++] = (-b - d) / (a * 2.0);
                 }
             }
@@ -2374,7 +2374,7 @@ public static int solveQuad(double[] eqn, double[] res) {
          */
         public static int solveCubic(double[] eqn, double[] res) {
             double d = eqn[3];
-            if (d == 0) {
+            if (isZero(d)) {
                 return solveQuad(eqn, res);
             }
             double a = eqn[2] / d;
@@ -2453,7 +2453,7 @@ public static int crossLine(double x1, double y1, double x2, double y2, double x
             if ((x < x1 && x < x2) ||
                     (x > x1 && x > x2) ||
                     (y > y1 && y > y2) ||
-                    (x1 == x2)) {
+                    (isZero(x1 - x2))) {
                 return 0;
             }
 
@@ -3025,14 +3025,14 @@ int cross(double[] res, int rc, double py1, double py2) {
                     }
                     // CURVE-START
                     if (t < DELTA) {
-                        if (py1 < 0.0 && (bx != 0.0 ? bx : ax - bx) < 0.0) {
+                        if (py1 < 0.0 && (!isZero(bx) ? bx : ax - bx) < 0.0) {
                             cross--;
                         }
                         continue;
                     }
                     // CURVE-END
                     if (t > 1 - DELTA) {
-                        if (py1 < ay && (ax != bx ? ax - bx : bx) > 0.0) {
+                        if (py1 < ay && (!isZero(ax - bx) ? ax - bx : bx) > 0.0) {
                             cross++;
                         }
                         continue;
@@ -3060,10 +3060,10 @@ int solvePoint(double[] res, double px) {
 
             int solveExtrem(double[] res) {
                 int rc = 0;
-                if (Ax != 0.0) {
+                if (!isZero(Ax)) {
                     res[rc++] = -Bx / (Ax + Ax);
                 }
-                if (Ay != 0.0) {
+                if (!isZero(Ay)) {
                     res[rc++] = -By / (Ay + Ay);
                 }
                 return rc;
@@ -3130,14 +3130,14 @@ int cross(double[] res, int rc, double py1, double py2) {
                     }
                     // CURVE-START
                     if (t < DELTA) {
-                        if (py1 < 0.0 && (bx != 0.0 ? bx : (cx != bx ? cx - bx : ax - cx)) < 0.0) {
+                        if (py1 < 0.0 && (!isZero(bx) ? bx : (!isZero(cx - bx) ? cx - bx : ax - cx)) < 0.0) {
                             cross--;
                         }
                         continue;
                     }
                     // CURVE-END
                     if (t > 1 - DELTA) {
-                        if (py1 < ay && (ax != cx ? ax - cx : (cx != bx ? cx - bx : bx)) > 0.0) {
+                        if (py1 < ay && (!isZero(ax - cx) ? ax - cx : (!isZero(cx - bx) ? cx - bx : bx)) > 0.0) {
                             cross++;
                         }
                         continue;
diff --git a/CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java b/CodenameOne/src/com/codename1/ui/layouts/LayeredLayout.java
@@ -3437,7 +3437,7 @@ public Inset translatePixels(int delta, boolean preferMM, Container parent) {
                                 return this;
                             }
                             float percentDelta = delta / relH * 100f;
-                            if (percentDelta == Float.NEGATIVE_INFINITY || percentDelta == Float.POSITIVE_INFINITY) {
+                            if (Float.compare(percentDelta, Float.NEGATIVE_INFINITY) == 0 || Float.compare(percentDelta, Float.POSITIVE_INFINITY) == 0) {
                                 percentDelta = 0f;
                             }
                             value += percentDelta;
@@ -3450,7 +3450,7 @@ public Inset translatePixels(int delta, boolean preferMM, Container parent) {
                             }
                             float percentDelta = delta / relH * 100f;
                             //System.out.println("percentDelta="+percentDelta);
-                            if (percentDelta == Float.NEGATIVE_INFINITY || percentDelta == Float.POSITIVE_INFINITY) {
+                            if (Float.compare(percentDelta, Float.NEGATIVE_INFINITY) == 0 || Float.compare(percentDelta, Float.POSITIVE_INFINITY) == 0) {
                                 percentDelta = 0f;
                             }
                             value += percentDelta;
diff --git a/CodenameOne/src/com/codename1/ui/plaf/Border.java b/CodenameOne/src/com/codename1/ui/plaf/Border.java
@@ -1102,7 +1102,7 @@ public boolean equals(Object obj) {
 
             boolean v = ((themeColors == b.themeColors) &&
                     (type == b.type) &&
-                    (thickness == b.thickness) &&
+                    (Float.compare(thickness, b.thickness) == 0) &&
                     (colorA == b.colorA) &&
                     (colorB == b.colorB) &&
                     (colorC == b.colorC) &&
diff --git a/CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java b/CodenameOne/src/com/codename1/ui/plaf/CSSBorder.java
@@ -1345,7 +1345,7 @@ ScalarUnit copy() {
         public boolean equals(Object obj) {
             if (obj instanceof ScalarUnit) {
                 ScalarUnit u = (ScalarUnit) obj;
-                return u.value == 0 && value == 0 || u.value == value && u.type == type;
+                return Float.compare(u.value, 0f) == 0 && Float.compare(value, 0f) == 0 || Float.compare(u.value, value) == 0 && u.type == type;
             }
             return false;
         }
diff --git a/CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java b/CodenameOne/src/com/codename1/ui/plaf/RoundRectBorder.java
@@ -330,7 +330,7 @@ public RoundRectBorder stroke(Stroke stroke) {
      */
     public RoundRectBorder stroke(float stroke, boolean mm) {
         strokeThickness = stroke;
-        if (strokeThickness == 0) {
+        if (Float.compare(strokeThickness, 0f) == 0) {
             this.stroke = null;
             return this;
         }
@@ -350,7 +350,7 @@ public RoundRectBorder stroke(float stroke, boolean mm) {
      * @return border instance so these calls can be chained
      */
     public RoundRectBorder shadowSpread(float shadowSpread) {
-        if (shadowSpread != this.shadowSpread) {
+        if (Float.compare(shadowSpread, this.shadowSpread) != 0) {
             this.shadowSpread = shadowSpread;
             dirty = true;
         }
@@ -404,7 +404,7 @@ public RoundRectBorder shadowColor(int shadowColor) {
      * @return border instance so these calls can be chained
      */
     public RoundRectBorder shadowX(float shadowX) {
-        if (shadowX != this.shadowX) {
+        if (Float.compare(shadowX, this.shadowX) != 0) {
             this.shadowX = shadowX;
             dirty = true;
         }
@@ -418,7 +418,7 @@ public RoundRectBorder shadowX(float shadowX) {
      * @return border instance so these calls can be chained
      */
     public RoundRectBorder shadowY(float shadowY) {
-        if (shadowY != this.shadowY) {
+        if (Float.compare(shadowY, this.shadowY) != 0) {
             this.shadowY = shadowY;
             dirty = true;
         }
@@ -432,7 +432,7 @@ public RoundRectBorder shadowY(float shadowY) {
      * @return border instance so these calls can be chained
      */
     public RoundRectBorder shadowBlur(float shadowBlur) {
-        if (shadowBlur != this.shadowBlur) {
+        if (Float.compare(shadowBlur, this.shadowBlur) != 0) {
             this.shadowBlur = shadowBlur;
             dirty = true;
         }
@@ -446,7 +446,7 @@ public RoundRectBorder shadowBlur(float shadowBlur) {
      * @return border instance so these calls can be chained
      */
     public RoundRectBorder cornerRadius(float cornerRadius) {
-        if (cornerRadius != this.cornerRadius) {
+        if (Float.compare(cornerRadius, this.cornerRadius) != 0) {
             this.cornerRadius = cornerRadius;
             dirty = true;
         }

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ public void remove(int index) {`
`188`	`188`	`XYEntry<Double, Double> removedEntry = mXY.removeByIndex(index);`
`189`	`189`	`double removedX = removedEntry.getKey();`
`190`	`190`	`double removedY = removedEntry.getValue();`
`191`		`- if (removedX == mMinX \|\| removedX == mMaxX \|\| removedY == mMinY \|\| removedY == mMaxY) {`
	`191`	`+ if (Double.compare(removedX, mMinX) == 0 \|\| Double.compare(removedX, mMaxX) == 0 \|\| Double.compare(removedY, mMinY) == 0 \|\| Double.compare(removedY, mMaxY) == 0) {`
`192`	`192`	`initRange();`
`193`	`193`	`}`
`194`	`194`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public void add(double x, double y) {`
`94`	`94`	`public void remove(int index) {`
`95`	`95`	`super.remove(index);`
`96`	`96`	`double removedValue = mValue.remove(index);`
`97`		`- if (removedValue == mMinValue \|\| removedValue == mMaxValue) {`
	`97`	`+ if (Double.compare(removedValue, mMinValue) == 0 \|\| Double.compare(removedValue, mMaxValue) == 0) {`
`98`	`98`	`initRange();`
`99`	`99`	`}`
`100`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ public int compare(Location o1, Location o2) {`
`294`	`294`	`*/`
`295`	`295`	`boolean equalsLatLng(Location l) {`
`296`	`296`
`297`		`- return l != null && l.latitude == latitude && l.longitude == longitude;`
	`297`	`+ return l != null && Double.compare(l.latitude, latitude) == 0 && Double.compare(l.longitude, longitude) == 0;`
`298`	`298`
`299`	`299`	`}`
`300`	`300`	`}`
Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ public void setMiterLimit(float miterLimit) {`
`227`	`227`	`public boolean equals(Object obj) {`
`228`	`228`	`if (obj instanceof Stroke) {`
`229`	`229`	`Stroke s = (Stroke) obj;`
`230`		`- return (s.miterLimit == miterLimit && s.capStyle == capStyle && s.joinStyle == joinStyle && s.lineWidth == lineWidth);`
	`230`	`+ return (Float.compare(s.miterLimit, miterLimit) == 0 && s.capStyle == capStyle && s.joinStyle == joinStyle && Float.compare(s.lineWidth, lineWidth) == 0);`
`231`	`231`	`}`
`232`	`232`	`return false;`
`233`	`233`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3437,7 +3437,7 @@ public Inset translatePixels(int delta, boolean preferMM, Container parent) {`
`3437`	`3437`	`return this;`
`3438`	`3438`	`}`
`3439`	`3439`	`float percentDelta = delta / relH * 100f;`
`3440`		`- if (percentDelta == Float.NEGATIVE_INFINITY \|\| percentDelta == Float.POSITIVE_INFINITY) {`
	`3440`	`+ if (Float.compare(percentDelta, Float.NEGATIVE_INFINITY) == 0 \|\| Float.compare(percentDelta, Float.POSITIVE_INFINITY) == 0) {`
`3441`	`3441`	`percentDelta = 0f;`
`3442`	`3442`	`}`
`3443`	`3443`	`value += percentDelta;`
`@@ -3450,7 +3450,7 @@ public Inset translatePixels(int delta, boolean preferMM, Container parent) {`
`3450`	`3450`	`}`
`3451`	`3451`	`float percentDelta = delta / relH * 100f;`
`3452`	`3452`	`//System.out.println("percentDelta="+percentDelta);`
`3453`		`- if (percentDelta == Float.NEGATIVE_INFINITY \|\| percentDelta == Float.POSITIVE_INFINITY) {`
	`3453`	`+ if (Float.compare(percentDelta, Float.NEGATIVE_INFINITY) == 0 \|\| Float.compare(percentDelta, Float.POSITIVE_INFINITY) == 0) {`
`3454`	`3454`	`percentDelta = 0f;`
`3455`	`3455`	`}`
`3456`	`3456`	`value += percentDelta;`
Original file line number	Diff line number	Diff line change
`@@ -1345,7 +1345,7 @@ ScalarUnit copy() {`
`1345`	`1345`	`public boolean equals(Object obj) {`
`1346`	`1346`	`if (obj instanceof ScalarUnit) {`
`1347`	`1347`	`ScalarUnit u = (ScalarUnit) obj;`
`1348`		`- return u.value == 0 && value == 0 \|\| u.value == value && u.type == type;`
	`1348`	`+ return Float.compare(u.value, 0f) == 0 && Float.compare(value, 0f) == 0 \|\| Float.compare(u.value, value) == 0 && u.type == type;`
`1349`	`1349`	`}`
`1350`	`1350`	`return false;`
`1351`	`1351`	`}`