Refactor LocationSimulation: Replace Google Maps with Open Street Map #3863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor LocationSimulation: Replace Google Maps with OpenStreetMap - Replaced the Google Maps implementation with OpenStreetMap in the LocationSimulation feature. - Enhanced the functionality to dynamically update form fields (latitude and longitude) when the map position changes. - Known Issue: When LocationSimulation is closed and reopened, the map does not display. The current workaround is to keep LocationSimulation open throughout the development process.
Contributor
Author
|
Refactor LocationSimulation: Replace Google Maps with OpenStreetMap
Known Issue:
|
shai-almog
requested changes
Jan 22, 2025
Ports/JavaSE/src/com/codename1/impl/javase/LocationSimulation.java
Outdated
Show resolved
Hide resolved
Ports/JavaSE/src/com/codename1/impl/javase/LocationSimulation.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Thanks! |
…oogle map page and change lambdas to anonymous classes to follow Java 7 syntax. Tested functionality using a bare-bones Java app via Codename One Initializr. pull request: codenameone#3863 issue: codenameone#3173 Known Issue: - When LocationSimulation is closed and reopened, the map does not display. -Workaround: Keep LocationSimulation open during the development process.
Contributor
Author
|
I have committed changes to remove the commented Google map page and changed lambdas to anonymous classes to comply with Java 7 syntax. 3863 |
Collaborator
|
Great job, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor LocationSimulation: Replace Google Maps with OpenStreetMap
Replaced the Google Maps implementation with OpenStreetMap in the LocationSimulation feature.
Enhanced the functionality to dynamically update form fields (latitude and longitude) when the map position changes.
Known Issue: When LocationSimulation is closed and reopened, the map does not display. The current workaround is to keep LocationSimulation open throughout the development process.