Skip to content

Conversation

@shai-almog
Copy link
Collaborator

Summary

  • add a reusable iOS simulator UI test harness that captures screenshots and uploads comparison reports
  • update the Codename One app template to expose UI states for automated testing and seed a UI test template during workspace generation
  • teach the screenshot comment tooling to support per-platform markers, headings, and log prefixes so Android and iOS reports coexist

Testing

  • Not run (requires macOS simulator and GitHub environment)

https://chatgpt.com/codex/tasks/task_e_68f1fc08a89083318bb6eb8582fd492e

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines 104 to 106
declare -a PNG_FILES=()
if mapfile -t PNG_FILES < <(find "$SCREENSHOT_RAW_DIR" -type f -name '*.png' -print | sort); then
:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace bash mapfile usage in iOS test runner

The new iOS screenshot harness enumerates PNGs with mapfile -t, but macOS GitHub runners invoke /usr/bin/env bash as the system Bash 3.2, which does not provide the mapfile/readarray builtin. When this job runs on the default macOS image the script will abort with mapfile: command not found before any screenshots are processed, causing the entire workflow step to fail even though the tests themselves may have passed. Iterate over find results with a POSIX‑compatible loop instead so the script works on the stock shell.

Useful? React with 👍 / 👎.

@shai-almog
Copy link
Collaborator Author

shai-almog commented Oct 17, 2025

✅ Native Android screenshot tests passed.

@shai-almog shai-almog closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants