Fix PMD warnings across UI and database modules

[shai-almog]

Summary

• simplify conditional logic and loop control to satisfy PMD checks across UI components
• remove unused members and redundant modifiers highlighted by PMD
• add minimal logging and accessors where needed to retain functionality while silencing warnings

Testing

• not run (not requested)

---

https://chatgpt.com/codex/tasks/task_e_68f269e1d9188331be776dd12aed8935

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 41 total, 0 failed, 0 skipped
• 📊 Line coverage: 2.95% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.services.RSSService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService – 0.00%
    • com.codename1.io.services.ImageDownloadService$6 – 0.00%
    • com.codename1.io.services.ImageDownloadService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService$3 – 0.00%
    • com.codename1.io.services.ImageDownloadService$2 – 0.00%
    • com.codename1.io.services.ImageDownloadService$5 – 0.00%
    • com.codename1.io.services.ImageDownloadService$4 – 0.00%
    • com.codename1.io.services.TwitterRESTService$1 – 0.00%
    • com.codename1.io.services.RSSService$1FinishParsing – 0.00%

Static Analysis

• ❌ SpotBugs: 2385 findings (High: 101, Normal: 1387, Low: 897) [HTML preview] [Download]
  • Top findings
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:39 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:31 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:34 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/views/XYChart.java:132 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
    • High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:49 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
    • …and 2380 more
• ❌ PMD: 3873 findings (P3: 1555, P4: 2318) [HTML preview] [Download]
  • Top findings
    • P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
    • P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8246 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:99 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/impl/VirtualKeyboardInterface.java:44 – Unnecessary modifier 'public' on method 'setInputType': the method is declared in an interface type (rule: UnnecessaryModifier)
    • P3: CodenameOne/src/com/codename1/impl/VirtualKeyboardInterface.java:51 – Unnecessary modifier 'public' on method 'getVirtualKeyboardName': the method is declared in an interface type (rule: UnnecessaryModifier)
    • …and 3868 more
• ❌ Checkstyle: 232450 findings (Warning: 232450) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:3 – Empty line should be followed by

      tag on the next line. (rule: JavadocParagraphCheck)

    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:7 – Empty line should be followed by

      tag on the next line. (rule: JavadocParagraphCheck)

    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:9 – Empty line should be followed by

      tag on the next line. (rule: JavadocParagraphCheck)

    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:16:1 – 'package' should be separated from previous line. (rule: EmptyLineSeparatorCheck)
    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:27:1 – Extra separation in import group before 'com.codename1.charts.util.MathHelper' (rule: CustomImportOrderCheck)
    • …and 232445 more

Generated automatically by the PR CI workflow.

[shai-almog]

✅ Native Android screenshot tests passed.