Fix spotbugs dead stores and parsing warnings

[shai-almog]

Summary

• remove dead stores and simplify bit reversing in gzip helper classes
• clean up unused locals and redundant computations across UI components and utilities
• streamline resource/theme parsing by eliminating unused values and avoiding unnecessary boxing

Testing

• mvn -pl CodenameOne -am -DskipTests compile (fails: module CodenameOne not found in reactor)

---

https://chatgpt.com/codex/tasks/task_e_68f3914ae9c88331ba0ef2348f09c3ce

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Header reader no longer consumes leading size field

The resource header previously read and discarded a 16‑bit size value before reading majorVersion, minorVersion, and the metadata length. The new code skips that first input.readShort(), so majorVersion now consumes the size field and everything that follows is offset by two bytes. This will corrupt the version values and almost certainly cause metaData length to be wrong, leading to malformed resource parsing or runtime failures whenever a .res file is loaded.

Useful? React with 👍 / 👎.

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 45 total, 0 failed, 0 skipped
• 📊 Line coverage: 3.07% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.services.RSSService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService – 0.00%
    • com.codename1.io.services.ImageDownloadService$6 – 0.00%
    • com.codename1.io.services.ImageDownloadService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService$3 – 0.00%
    • com.codename1.io.services.ImageDownloadService$2 – 0.00%
    • com.codename1.io.services.ImageDownloadService$5 – 0.00%
    • com.codename1.io.services.ImageDownloadService$4 – 0.00%
    • com.codename1.io.services.TwitterRESTService$1 – 0.00%
    • com.codename1.io.services.RSSService$1FinishParsing – 0.00%

Static Analysis

• ❌ SpotBugs: 993 findings (High: 92, Normal: 484, Low: 417) [HTML preview] [Download]
  • Top findings
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
    • High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
    • …and 988 more
• ❌ PMD: 2726 findings (P2: 1, P3: 649, P4: 2076) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1012 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
    • P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8380 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • …and 2721 more
• ❌ Checkstyle: 180067 findings (Warning: 180067) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:3 –

      tag should be placed immediately before the first word, with no space after. (rule: JavadocParagraphCheck)

    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:3 –

      tag should be preceded with an empty line. (rule: JavadocParagraphCheck)

    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:7 –

      tag should be placed immediately before the first word, with no space after. (rule: JavadocParagraphCheck)

    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:7 –

      tag should be preceded with an empty line. (rule: JavadocParagraphCheck)

    • Warning: CodenameOne/src/com/codename1/charts/models/XYSeries.java:9 –

      tag should be placed immediately before the first word, with no space after. (rule: JavadocParagraphCheck)

    • …and 180062 more

Generated automatically by the PR CI workflow.

[shai-almog]

✅ Native Android screenshot tests passed.