Skip to content

Conversation

@shai-almog
Copy link
Collaborator

Summary

  • add a workflow that builds the developer guide HTML and PDF with Asciidoctor
  • upload the generated documentation as PR artifacts and release assets
  • comment on affected pull requests with direct links to the downloadable artifacts

Testing

  • not run

https://chatgpt.com/codex/tasks/task_e_68f59290abc88331aacb054a59356751

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +103 to +107
await github.rest.issues.createComment({
owner,
repo,
issue_number: context.issue.number,
body

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Handle lack of write permissions on forked PR comment step

The workflow tries to call issues.createComment using the default GITHUB_TOKEN whenever it runs on a pull request. For PRs opened from forks, that token is read‑only and cannot write to issues or PRs. When such a forked PR touches the developer guide, this step will consistently fail with a 403, causing the entire workflow to report failure even though the documentation build succeeded and no comment was required. Consider guarding the comment step behind a permission check, switching to pull_request_target, or marking the step continue-on-error so forked contributions do not see a failing check.

Useful? React with 👍 / 👎.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Developer Guide build artifacts are available for download from this workflow run:

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog shai-almog merged commit c46cf4e into master Oct 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants