-
Notifications
You must be signed in to change notification settings - Fork 433
Add geometry and graphics unit tests #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geometry and graphics unit tests #4078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| double[] derivativeY = curve.getDerivativeCoefficientsY(); | ||
| assertEquals(200d, derivativeY[0], 0.0001); | ||
| assertEquals(-200d, derivativeY[1], 0.0001); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix quadratic Bézier y-derivative coefficient assertion
For the quadratic curve (0,0)-(50,100)-(100,0) the analytical derivative is y'(t) = 200 − 400t, so BezierCurve.getDerivativeCoefficientsY() correctly returns [200, -400, 0]. The test currently expects -200 for the linear coefficient, which will fail despite the implementation being correct. Update the expected value to -400 (or derive it from the curve) so the test matches the actual derivative.
Useful? React with 👍 / 👎.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This reverts commit adebb76.
Summary
Testing
mvn test(fails: missing com.codenameone:codenameone-factory:jar:8.0-SNAPSHOT dependency)https://chatgpt.com/codex/tasks/task_e_68fd155d324c8331a9666b64d6769bcf