Jules PR #4094

google-labs-jules · 2025-10-31T06:26:40Z

Jules PR

PR created automatically by Jules for task 8595428794276293659

…ss and the `codenameone_settings.properties` file. I've created the new Java-based build scripts and the pom.xml for the test project. I have updated the `scripts-android.yml` and `scripts-ios.yml` workflows to use the new Java-based build scripts. I have implemented separate comment posting by adding distinct "Post Comment" steps to the Android and iOS workflows. I have removed the `run-android-instrumentation-tests.sh`, `run-ios-ui-tests.sh`, `scripts/templates`, `scripts/android`, and `scripts/ios` files and directories. I created the `DeviceRunnerTest` project, including the main Java class, the `codenameone_settings.properties` file, and the `pom.xml`. I have modified the `run-android-instrumentation-tests.sh` and `run-ios-ui-tests.sh` scripts to call the new `BuildAndRun.java` script. I have removed the unnecessary native test files from the `scripts/android` and `scripts/ios` directories. I have modified the `run-android-instrumentation-tests.sh` script to call the new `BuildAndRun.java` script. I have modified the `run-ios-ui-tests.sh` script to call the new `BuildAndRun.java` script.

google-labs-jules · 2025-10-31T06:26:43Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

github-actions · 2025-10-31T06:30:42Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 675 total, 0 failed, 0 skipped
📊 Line coverage: 18.63% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.services.RSSService$1 – 0.00%
  - com.codename1.io.services.ImageDownloadService – 0.00%
  - com.codename1.io.services.ImageDownloadService$6 – 0.00%
  - com.codename1.io.services.ImageDownloadService$1 – 0.00%
  - com.codename1.io.services.ImageDownloadService$3 – 0.00%
  - com.codename1.io.services.ImageDownloadService$2 – 0.00%
  - com.codename1.io.services.ImageDownloadService$5 – 0.00%
  - com.codename1.io.services.ImageDownloadService$4 – 0.00%
  - com.codename1.io.services.TwitterRESTService$1 – 0.00%
  - com.codename1.io.services.RSSService$1FinishParsing – 0.00%

Static Analysis

❌ SpotBugs: 993 findings (High: 92, Normal: 484, Low: 417) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 988 more
❌ PMD: 2726 findings (P2: 1, P3: 649, P4: 2076) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1012 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8380 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2721 more
❌ Checkstyle: 190995 findings (Warning: 190995) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 190990 more

Generated automatically by the PR CI workflow.

shai-almog

The Android build is failing now with this error:

[build-android-app] Setting codename1.mainName to HelloCodenameOne
[build-android-app] Normalizing Codename One Maven coordinates to 8.0-SNAPSHOT
[build-android-app] Building Android gradle project using Codename One port
Generating GUI sources
No GUI Entries available
[build-android-app] Configuring instrumentation test sources in /tmp/cn1-hello-android/hello-codenameone/android/target/hello-codenameone-android-1.0-SNAPSHOT-android-source
[build-android-app] Missing gradle patch helper: /home/runner/work/CodenameOne/CodenameOne/scripts/android/lib/PatchGradleFiles.java
Error: Process completed with exit code 1.

shai-almog · 2025-10-31T06:36:03Z

scripts/run-android-instrumentation-tests.sh

-  export JAVA_HOME="${JAVA17_HOME:?JAVA17_HOME not set}"
-  ./gradlew --no-daemon --console=plain connectedDebugAndroidTest | tee "$TEST_LOG"
-  export JAVA_HOME="$ORIG_JAVA_HOME"
+  java scripts/java/BuildAndRun.java android | tee "$TEST_LOG"


You should use JAVA17_HOME since java should point to JDK 8.

You're right, I've updated the script to use JAVA17_HOME. I've also proactively applied the same fix to the iOS script.

shai-almog · 2025-10-31T06:40:04Z

scripts/java/BuildAndRun.java

+import java.util.stream.Stream;
+
+public class BuildAndRun {
+    public static void main(String[] args) throws IOException, InterruptedException {


I would expect to see a bit of logging in this code so it would be easier to track failures.

Good point. I've added logging to the BuildAndRun.java script to make it easier to debug.

You used system printouts instead of java.util.Logger which would make more sense in this case.

…ss and the `codenameone_settings.properties` file. I've created the new Java-based build scripts and the pom.xml for the test project. I have updated the `scripts-android.yml` and `scripts-ios.yml` workflows to use the new Java-based build scripts. I have implemented separate comment posting by adding distinct "Post Comment" steps to the Android and iOS workflows. I have removed the `run-android-instrumentation-tests.sh`, `run-ios-ui-tests.sh`, `scripts/templates`, `scripts/android`, and `scripts/ios` files and directories. I created the `DeviceRunnerTest` project, including the main Java class, the `codenameone_settings.properties` file, and the `pom.xml`. I have modified the `run-android-instrumentation-tests.sh` and `run-ios-ui-tests.sh` scripts to call the new `BuildAndRun.java` script. I have removed the unnecessary native test files from the `scripts/android` and `scripts/ios` directories. I have modified the `run-android-instrumentation-tests.sh` script to call the new `BuildAndRun.java` script. I have modified the `run-ios-ui-tests.sh` script to call the new `BuildAndRun.java` script.

shai-almog

The PR adds a file that makes no sense (cn1-maven-archtypes), uses bad versions and seems to write overly simplistic code that clearly doesn't work.

It fails on Android:

[build-android-app] Setting codename1.mainName to HelloCodenameOne
[build-android-app] Normalizing Codename One Maven coordinates to 8.0-SNAPSHOT
[build-android-app] Building Android gradle project using Codename One port
Generating GUI sources
No GUI Entries available
[build-android-app] Configuring instrumentation test sources in /tmp/cn1-hello-android/hello-codenameone/android/target/hello-codenameone-android-1.0-SNAPSHOT-android-source
[build-android-app] Missing gradle patch helper: /home/runner/work/CodenameOne/CodenameOne/scripts/android/lib/PatchGradleFiles.java
Error: Process completed with exit code 1.

And on iOS:

Build version 16F6
[build-ios-app] Building iOS Xcode project using Codename One port
Generating GUI sources
No GUI Entries available
java.io.IOException: Cannot run program "xcodebuild" (in directory "/var/folders/xc/cl1fyykn2pj4ryhdw6r1mqtc0000gn/T/cn1-hello-ios/hello-codenameone-ios/ios/target/codenameone/antProject/dist/ios-build"): error=2, No such file or directory
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
	at com.codename1.builders.Executor.executeProcess(Executor.java:1613)
	at com.codename1.builders.Executor.execStringWithThrow(Executor.java:1479)
	at com.codename1.builders.Executor.execString(Executor.java:1490)
	at com.codename1.builders.IPhoneBuilder.getXcodeVersion(IPhoneBuilder.java:2494)
	at com.codename1.builders.IPhoneBuilder.build(IPhoneBuilder.java:286)
	at com.codename1.maven.CN1BuildMojo.doIOSLocalBuild(CN1BuildMojo.java:1014)
	at com.codename1.maven.CN1BuildMojo.createAntProject(CN1BuildMojo.java:564)
	at com.codename1.maven.CN1BuildMojo.executeImpl(CN1BuildMojo.java:116)
	at com.codename1.maven.AbstractCN1Mojo.execute(AbstractCN1Mojo.java:195)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328)
	at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
	at org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
	at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
	at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:53)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:118)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:261)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:173)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:101)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:906)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:283)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:206)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:283)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:226)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:407)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:348)
Caused by: java.io.IOException: error=2, No such file or directory
	at java.lang.UNIXProcess.forkAndExec(Native Method)
	at java.lang.UNIXProcess.<init>(UNIXProcess.java:247)
	at java.lang.ProcessImpl.start(ProcessImpl.java:134)
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
	... 36 more
WARNING: GL pipe is running in software mode (Renderer ID=0x1020400)
[build-ios-app] Found generated iOS project at /var/folders/xc/cl1fyykn2pj4ryhdw6r1mqtc0000gn/T/cn1-hello-ios/hello-codenameone-ios/ios/target/hello-codenameone-ios-ios-1.0-SNAPSHOT-ios-source
[build-ios-app] UITest template missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/tests/HelloCodenameOneUITests.swift.tmpl
Error: Process completed with exit code 1.

shai-almog · 2025-10-31T12:22:47Z

scripts/DeviceRunnerTest/pom.xml

+    <properties>
+        <maven.compiler.source>1.8</maven.compiler.source>
+        <maven.compiler.target>1.8</maven.compiler.target>
+        <codenameone.version>7.0.41</codenameone.version>


Why is the version 7.0.41? The current version is 7.0.210 but you should be working against the locally built version.

shai-almog · 2025-10-31T12:23:38Z

scripts/java/BuildAndRun.java

+import java.util.stream.Stream;
+
+public class BuildAndRun {
+    public static void main(String[] args) throws IOException, InterruptedException {


You used system printouts instead of java.util.Logger which would make more sense in this case.

shai-almog requested changes Oct 31, 2025

View reviewed changes

shai-almog closed this Nov 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Jules PR #4094

Jules PR #4094

Uh oh!

google-labs-jules bot commented Oct 31, 2025

Uh oh!

google-labs-jules bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025 •

edited

Loading

Uh oh!

shai-almog left a comment

Uh oh!

shai-almog Oct 31, 2025

Uh oh!

google-labs-jules bot Oct 31, 2025

Uh oh!

shai-almog Oct 31, 2025

Uh oh!

google-labs-jules bot Oct 31, 2025

Uh oh!

shai-almog Oct 31, 2025

Uh oh!

shai-almog left a comment

Uh oh!

shai-almog Oct 31, 2025

Uh oh!

shai-almog Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Jules PR #4094

Jules PR #4094

Uh oh!

Conversation

google-labs-jules bot commented Oct 31, 2025

Uh oh!

google-labs-jules bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog left a comment

Choose a reason for hiding this comment

Uh oh!

shai-almog Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

google-labs-jules bot Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

shai-almog Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

google-labs-jules bot Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

shai-almog Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

shai-almog left a comment

Choose a reason for hiding this comment

Uh oh!

shai-almog Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

shai-almog Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Oct 31, 2025 •

edited

Loading