Initial support for Android native screenshot functionality #4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
378
to
382
| @Override | ||
| public void screenshot(SuccessCallback<Image> callback) { | ||
| final Activity activity = (Activity) getContext(); | ||
| final AndroidScreenshotTask task = new AndroidScreenshotTask(this, activity, callback); | ||
| activity.runOnUiThread(task); |
There was a problem hiding this comment.
The new screenshot() override instantiates AndroidScreenshotTask with this. The task’s constructor requires an AndroidAsyncView, but the current class is AndroidImplementation. This code will not compile and the feature never builds. You likely intended to pass the existing surface (myView or its Android view) instead of the implementation instance.
Useful? React with 👍 / 👎.
Comment on lines
105
to
110
| private void postError(final Throwable t) { | ||
| if (callback == null) return; | ||
| Display.getInstance().callSerially(new Runnable() { | ||
| @Override public void run() { | ||
| callback.onError(t); | ||
| } |
There was a problem hiding this comment.
AndroidScreenshotTask.postError() invokes callback.onError(t) even though the declared type is SuccessCallback<Image>, whose only method is onSucess(T). This is a compile‑time error; the class won’t build. Use the proper callback type (e.g., Callback) or remove the error invocation.
Useful? React with 👍 / 👎.
shai-almog
force-pushed
the
screenshot-grab-api
branch
2 times, most recently
from
88e73a3 to
d0602af
Compare
shai-almog
force-pushed
the
screenshot-grab-api
branch
from
d0602af to
012d1bc
Compare
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
|
✅ Native Android screenshot tests passed. |
shai-almog
force-pushed
the
screenshot-grab-api
branch
from
eac9337 to
1edce58
Compare
shai-almog
force-pushed
the
screenshot-grab-api
branch
from
1edce58 to
86e2ac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.