Fix screenshot API in Android implementation #4107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The screenshot() method in AndroidImplementation was missing PeerComponents (native Android views like BrowserComponent, MapView, etc.) in the captured image on devices running Android < API 26 (Oreo). The issue was in the AndroidScreenshotTask.tryFallbackDraw() method, which only drew the CodenameOneSurface view itself. PeerComponents are added as siblings to the CodenameOneSurface within the parent RelativeLayout container, so they were not being captured. The fix: - Draw the parent container (RelativeLayout) instead of just the view - Calculate and apply proper canvas translation to align the content - Maintain backward compatibility by falling back to view-only drawing if no parent is found Note: The PixelCopy method (API 26+) already worked correctly as it captures the entire window, so this only affects older Android versions.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
Author
Android screenshot updates
|
shai-almog
pushed a commit
that referenced
this pull request
Nov 8, 2025
The CI instrumentation test was using Android's native View.draw() method to capture screenshots, which doesn't properly include PeerComponents like BrowserComponent (native WebView). This change updates the test to use Codename One's screenshot API (Display.getInstance().screenshot()) which properly captures native widgets via the AndroidScreenshotTask implementation that was fixed in PR #4107. Key changes: - Replace direct View.draw() with CN1 screenshot API - Add proper synchronization using CountDownLatch - Convert CN1 Image to Android Bitmap for encoding - Maintain same output format for CI pipeline compatibility This ensures BrowserComponent and other native widgets are now visible in CI screenshots.
shai-almog
pushed a commit
that referenced
this pull request
Nov 8, 2025
The CI instrumentation test was using Android's native View.draw() method to capture screenshots, which doesn't properly include PeerComponents like BrowserComponent (native WebView). This change updates the test to use Codename One's screenshot API (Display.getInstance().screenshot()) which properly captures native widgets via the AndroidScreenshotTask implementation that was fixed in PR #4107. Key changes: - Replace direct View.draw() with CN1 screenshot API - Add proper synchronization using CountDownLatch - Convert CN1 Image to Android Bitmap for encoding - Maintain same output format for CI pipeline compatibility This ensures BrowserComponent and other native widgets are now visible in CI screenshots.
shai-almog
added a commit
that referenced
this pull request
Nov 8, 2025
The CI instrumentation test was using Android's native View.draw() method to capture screenshots, which doesn't properly include PeerComponents like BrowserComponent (native WebView). This change updates the test to use Codename One's screenshot API (Display.getInstance().screenshot()) which properly captures native widgets via the AndroidScreenshotTask implementation that was fixed in PR #4107. Key changes: - Replace direct View.draw() with CN1 screenshot API - Add proper synchronization using CountDownLatch - Convert CN1 Image to Android Bitmap for encoding - Maintain same output format for CI pipeline compatibility This ensures BrowserComponent and other native widgets are now visible in CI screenshots. Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screenshot() method in AndroidImplementation was missing PeerComponents (native Android views like BrowserComponent, MapView, etc.) in the captured image on devices running Android < API 26 (Oreo).
The issue was in the AndroidScreenshotTask.tryFallbackDraw() method, which only drew the CodenameOneSurface view itself. PeerComponents are added as siblings to the CodenameOneSurface within the parent RelativeLayout container, so they were not being captured.
The fix:
Note: The PixelCopy method (API 26+) already worked correctly as it captures the entire window, so this only affects older Android versions.