Skip to content

Separate preview uploads for iOS and Android screenshot comments #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 3 commits into from
Nov 11, 2025
Merged

Separate preview uploads for iOS and Android screenshot comments #4125

shai-almog merged 3 commits into from
Nov 11, 2025

Conversation

@shai-almog
Copy link
Collaborator

@shai-almog shai-almog commented Nov 11, 2025

Summary

  • allow the screenshot comment helper to write preview images into a configurable subdirectory
  • propagate the new preview subdirectory option through the shared cn1ss wrapper
  • scope Android and iOS workflows to distinct preview directories so their PR comments use the correct images

Testing

  • not run (not requested)

Codex Task

@shai-almog
Copy link
Collaborator Author

shai-almog commented Nov 11, 2025 •
edited
Loading

✅ Native Android screenshot tests passed.

@shai-almog
Copy link
Collaborator Author

shai-almog commented Nov 11, 2025 •
edited
Loading

iOS screenshot updates

  • BrowserComponent — updated screenshot. Screenshot differs (1179x2556 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

@shai-almog shai-almog merged commit 3735a2a into master Nov 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shai-almog