Fixed some of the problems in the code #4128
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } catch (Throwable ex) { | ||
| Log.e(ex); | ||
| } finally { | ||
| queued = false; | ||
| Util.cleanup(i); |
There was a problem hiding this comment.
The background load in StorageImageAsync.getImageData() now clears queued only inside the serially executed UI callback, but the finally block no longer resets it. If Storage.getInstance().readObject(fileName) throws before the callback is scheduled, the code reaches this catch/finally without ever clearing queued. Subsequent calls will keep returning early because queued is still true, so the image never retries loading after a transient storage failure. Clearing queued in the error path or finally block avoids permanently disabling future loads.
Useful? React with 👍 / 👎.
Android screenshot updates
|
|
✅ Native iOS screenshot tests passed. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
No description provided.