Add graphics pipeline screenshot test #4142

shai-almog · 2025-11-19T01:15:45Z

Summary

add a graphics pipeline screenshot test covering primitives, gradients, alpha, clipping, and affine transforms
include the new test in the device runner suite for automated screenshots

Testing

Not run (not requested)

Codex Task

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-19T01:20:47Z

scripts/device-runner-app/tests/GraphicsPipelineScreenshotTest.java

+            }
+
+            g.setColor(0xf8fafc);
+            g.drawString("translate + affine", -58, 4);
+            g.translate(-cx, -cy);


Preserve translation when undoing transform center

When isAffineSupported() is true (e.g., Android and JavaSE ports), resetAffine() clears the translate(cx, cy) applied earlier in drawTransforms, so the subsequent translate(-cx, -cy) leaves the graphics context shifted to a negative origin and the label in this block is drawn at negative coordinates. That means the rest of the showcase (other quadrants) will render off-canvas whenever affine transforms are enabled, defeating the screenshot’s intent.

Useful? React with 👍 / 👎.

shai-almog · 2025-11-19T01:33:19Z

Compared 2 screenshots: 2 matched.

Native Android coverage

📊 Line coverage: 12.33% (1327/10763 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 10.72% (5440/50756), branch 7.96% (375/4714), complexity 8.51% (363/4267), method 16.99% (310/1825), class 19.41% (59/304)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/398 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.CodenameOneInputConnection – 0.00% (0/109 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)

github-actions · 2025-11-19T02:54:14Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 1940 total, 0 failed, 0 skipped
📊 Line coverage: 39.83% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.services.RSSService$1 – 0.00%
  - com.codename1.io.services.TwitterRESTService – 0.00%
  - com.codename1.io.services.ImageDownloadService$6 – 0.00%
  - com.codename1.io.services.ImageDownloadService$1 – 0.00%
  - com.codename1.io.services.ImageDownloadService$3 – 0.00%
  - com.codename1.io.services.ImageDownloadService$2 – 0.00%
  - com.codename1.io.services.ImageDownloadService$5 – 0.00%
  - com.codename1.io.services.ImageDownloadService$4 – 0.00%
  - com.codename1.io.services.TwitterRESTService$1 – 0.00%
  - com.codename1.io.services.RSSService – 0.00%

Static Analysis

❌ SpotBugs: 994 findings (High: 92, Normal: 484, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 989 more
❌ PMD: 2727 findings (P2: 1, P3: 649, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1009 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8394 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 206148 findings (Warning: 206148) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 206143 more

Generated automatically by the PR CI workflow.

shai-almog · 2025-11-19T04:10:38Z

iOS screenshot updates

Compared 8 screenshots: 2 matched, 6 missing references.

Graphics.getTranslateX__ — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/Graphics.getTranslateX__.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 825x1789.
Full-resolution PNG saved as Graphics.getTranslateX__.png in workflow artifacts.
GraphicsPipeline — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsPipeline.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsPipeline.png in workflow artifacts.
GraphicsShapesAndGradients — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsShapesAndGradients.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsShapesAndGradients.png in workflow artifacts.
GraphicsStateAndText — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsStateAndText.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsStateAndText.png in workflow artifacts.
GraphicsTransformations — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsTransformations.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsTransformations.png in workflow artifacts.
MediaPlayback — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/MediaPlayback.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

Add graphics pipeline screenshot test

013a4cd

shai-almog added the codex label Nov 19, 2025 — with ChatGPT Codex Connector

chatgpt-codex-connector bot reviewed Nov 19, 2025

View reviewed changes

Add comprehensive graphics method screenshot tests

7e870a4

shai-almog added 3 commits November 19, 2025 03:45

Fix graphics screenshot test dependencies

eb3335c

Fix LinearGradientPaint construction in screenshot test

92931bd

Add per-method graphics screenshots and trigger iOS runs

d9e267e

shai-almog added 2 commits November 19, 2025 05:28

Fix graphics screenshot compatibility and PR workflow triggers

d3fbd67

Remove reflection in graphics methods screenshot test

aea8c10

shai-almog merged commit de71c18 into master Nov 19, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add graphics pipeline screenshot test #4142

Add graphics pipeline screenshot test #4142

Uh oh!

shai-almog commented Nov 19, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Nov 19, 2025

Uh oh!

shai-almog commented Nov 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

shai-almog commented Nov 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add graphics pipeline screenshot test #4142

Add graphics pipeline screenshot test #4142

Uh oh!

Conversation

shai-almog commented Nov 19, 2025

Summary

Testing

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

shai-almog commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading

shai-almog commented Nov 19, 2025 •

edited

Loading