-
Notifications
You must be signed in to change notification settings - Fork 433
Removed Android channel filtering #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
CodenameOne/scripts/android/tests/Cn1ssChunkTools.java
Lines 103 to 106 in cf73135
| String targetTest = test != null ? test : DEFAULT_TEST_NAME; | |
| List<Chunk> chunks = new ArrayList<>(); | |
| for (Chunk chunk : iterateChunks(path, Optional.ofNullable(targetTest), Optional.ofNullable(channel))) { | |
| chunks.add(chunk); |
The extract command now defaults channel to null, so iterateChunks(..., Optional.ofNullable(channel)) no longer filters when the caller omits --channel. The CN1SS helper scripts (e.g. cn1ss_decode_test_png in scripts/lib/cn1ss.sh) rely on that default filter and invoke extract without a channel to pull only the primary PNG stream while ignoring the CN1SSPREVIEW JPEG stream. With the filter removed, both channels’ chunks are concatenated together, their indices collide, and the assembled base64 fails PNG verification, preventing screenshots from being reconstructed in any log that contains preview chunks (the normal case). Default behavior needs to keep filtering on the empty channel or the scripts must be updated to pass a channel explicitly.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cf73135 to
791a30a
Compare
This reverts commit 5475e07.
|
This branch took the wrong turn because AI missed its own bug |



















































































































































































No description provided.