Simplified pipelines and made deeper reuse across them #4160
Conversation
Removed the JavaSE ports screemshot tests since it was badly done. Will revisit this in a future PR.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
CodenameOne/scripts/build-android-app.sh
Lines 195 to 199 in 735e41e
Android tests path uses undefined PACKAGE_PATH
In build-android-app.sh, the instrumentation test path is built with ${PACKAGE_PATH} but the earlier package-name definitions were removed. Because the script runs with set -u, reaching this line aborts the build before any tests are copied or Gradle runs, so the Android sample cannot be built.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
scripts/build-ios-app.sh
Outdated
| CN1_VERSION="8.0-SNAPSHOT" | ||
| WORK_DIR="scripts/hellocodenameone" | ||
| rm -rf "$WORK_DIR"; mkdir -p "$WORK_DIR" |
There was a problem hiding this comment.
build-ios-app.sh now wipes scripts/hellocodenameone (rm -rf "$WORK_DIR") but the skeleton generation step was removed, so the directory stays empty while the subsequent xmlstarlet edits expect pom.xml to exist. Running the script will therefore stop immediately with a missing-file error before any iOS project is built.
Useful? React with 👍 / 👎.
scripts/build-ios-app.sh
Outdated
| EXTRA_MVN_ARGS+=("-Dcodenameone.version=${CN1_VERSION}") | ||
|
|
||
| SETTINGS_FILE="$APP_DIR/common/codenameone_settings.properties" | ||
| if [ ! -f "$SETTINGS_FILE" ]; then | ||
| bia_log "codenameone_settings.properties not found at $SETTINGS_FILE" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| set_property() { | ||
| local key="$1" value="$2" | ||
| if grep -q "^${key}=" "$SETTINGS_FILE"; then | ||
| if sed --version >/dev/null 2>&1; then | ||
| sed -i -E "s|^${key}=.*$|${key}=${value}|" "$SETTINGS_FILE" | ||
| else | ||
| sed -i '' -E "s|^${key}=.*$|${key}=${value}|" "$SETTINGS_FILE" | ||
| fi | ||
| else | ||
| printf '\n%s=%s\n' "$key" "$value" >> "$SETTINGS_FILE" | ||
| fi | ||
| } | ||
|
|
||
| set_property "codename1.packageName" "$PACKAGE_NAME" | ||
| set_property "codename1.mainName" "$MAIN_NAME" | ||
|
|
||
| # Ensure trailing newline | ||
| tail -c1 "$SETTINGS_FILE" | read -r _ || echo >> "$SETTINGS_FILE" |
There was a problem hiding this comment.
The iOS build script calls tail -c1 "$SETTINGS_FILE" even though SETTINGS_FILE is never defined after the refactor. With set -u enabled, any invocation now exits with an unbound variable error before Maven or xcodebuild are run.
Useful? React with 👍 / 👎.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
iOS screenshot updatesCompared 6 screenshots: 0 matched, 2 updated, 4 missing references.
|
Android screenshot updatesCompared 4 screenshots: 1 matched, 1 updated, 2 missing references.
Native Android coverage
|
Removed the JavaSE ports screemshot tests since it was badly done. Will revisit this in a future PR.