Cleaned up test execution and made it more sensible #4163

shai-almog · 2025-11-24T18:36:58Z

No description provided.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-24T18:41:37Z

...n/src/main/java/com/codenameone/examples/hellocodenameone/tests/Cn1ssDeviceRunnerHelper.java

        if (img[0] == null) {
            println("CN1SS:ERR:test=" + safeName + " message=Screenshot process timed out");
            println("CN1SS:END:" + safeName);
-            return false;
        }
        Image screenshot = img[0];


Return after screenshot errors to avoid null dereference

When img[0] stays null (e.g., screenshot capture times out) the code only logs the error and then immediately assigns Image screenshot = img[0], continuing on to io.save(...) a few lines later. The same pattern applies to the PNG encoder check below. On devices where capture or PNG support fails, this flow will hit a NullPointerException and abort the suite instead of reporting the failure. Please return early once these error paths are hit.

Useful? React with 👍 / 👎.

.../common/src/main/java/com/codenameone/examples/hellocodenameone/tests/Cn1ssDeviceRunner.java

shai-almog · 2025-11-24T19:03:25Z

Android screenshot updates

Compared 7 screenshots: 6 matched, 1 updated.

BrowserComponent — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

Native Android coverage

📊 Line coverage: 18.33% (1975/10772 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 18.04% (9161/50777), branch 9.69% (457/4716), complexity 12.74% (544/4269), method 25.41% (464/1826), class 26.97% (82/304)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/398 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.CodenameOneInputConnection – 0.00% (0/109 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)

shai-almog · 2025-11-24T19:12:43Z

iOS screenshot updates

Compared 7 screenshots: 0 matched, 2 updated, 5 missing references.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
GraphicsPipeline — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsPipeline.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsPipeline.png in workflow artifacts.
GraphicsShapesAndGradients — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsShapesAndGradients.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsShapesAndGradients.png in workflow artifacts.
GraphicsStateAndText — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsStateAndText.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsStateAndText.png in workflow artifacts.
GraphicsTransformations — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsTransformations.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsTransformations.png in workflow artifacts.
MainActivity — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MainActivity.png in workflow artifacts.
MediaPlayback — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/MediaPlayback.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

github-actions · 2025-11-28T04:43:52Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 1990 total, 0 failed, 0 skipped
📊 Line coverage: 44.65% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.services.RSSService$1 – 0.00%
  - com.codename1.io.services.TwitterRESTService – 0.00%
  - com.codename1.io.services.ImageDownloadService$6 – 0.00%
  - com.codename1.io.services.ImageDownloadService$1 – 0.00%
  - com.codename1.io.services.ImageDownloadService$3 – 0.00%
  - com.codename1.io.services.ImageDownloadService$2 – 0.00%
  - com.codename1.io.services.ImageDownloadService$5 – 0.00%
  - com.codename1.io.services.ImageDownloadService$4 – 0.00%
  - com.codename1.io.services.TwitterRESTService$1 – 0.00%
  - com.codename1.io.services.RSSService – 0.00%

Static Analysis

❌ SpotBugs: 995 findings (High: 92, Normal: 485, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 990 more
❌ PMD: 2727 findings (P2: 1, P3: 649, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 207993 findings (Warning: 207993) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 207988 more

Generated automatically by the PR CI workflow.

Cleaned up test execution and made it more sensible

b7b9069

chatgpt-codex-connector bot reviewed Nov 24, 2025

View reviewed changes

Enabled CI for changes to the screenshot tests

e92fae0

shai-almog added 11 commits November 26, 2025 08:04

Added improved failure logging

77fb82c

Added gradle error logging

c3e0857

Too much debug info

8b439e1

Increased Android timeout

e7bf260

Fix for Android crash

0592743

Bash sucks so badly...

56ffc70

Fixed line processing code

ea48398

Is the timeout due to JIT optimizations?

72a6d15

Added an EDT error handler to see if there's a chance

875e608

Trying to add stack traces to logging

6509bb9

Added a way to print stack traces on Android

1142871

shai-almog force-pushed the fix-screenshot-test-execution branch from d9c3e14 to 1142871 Compare November 28, 2025 04:42

Maybe the stack was too long and got cropped

45aec5e

shai-almog force-pushed the fix-screenshot-test-execution branch from 84f28fa to 45aec5e Compare November 28, 2025 05:43

shai-almog added 5 commits November 28, 2025 08:20

WTF

8947a1a

Trying to build the plugin too

4078eac

Fixed drawShadow bug

2347c5e

Fixed media test

596f813

Updated screenshots and refined browser test

f604f6c

shai-almog merged commit d911b24 into master Nov 28, 2025
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cleaned up test execution and made it more sensible #4163

Cleaned up test execution and made it more sensible #4163

Uh oh!

shai-almog commented Nov 24, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Nov 24, 2025

Uh oh!

Uh oh!

shai-almog commented Nov 24, 2025 •

edited

Loading

Uh oh!

shai-almog commented Nov 24, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Cleaned up test execution and made it more sensible #4163

Cleaned up test execution and made it more sensible #4163

Uh oh!

Conversation

shai-almog commented Nov 24, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shai-almog commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android screenshot updates

Native Android coverage

Uh oh!

shai-almog commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Uh oh!

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Nov 24, 2025 •

edited

Loading

shai-almog commented Nov 24, 2025 •

edited

Loading

github-actions bot commented Nov 28, 2025 •

edited

Loading