Refine desktop window handling #4171

shai-almog · 2025-11-26T04:46:29Z

Summary

route initial window sizing hints through the implementation so JavaSE desktop windows size themselves before packing
remove the unused desktop monitor count API and avoid redundant cloning of window metrics
adjust JavaSE and test implementations plus unit tests for the updated window sizing behavior

Testing

mvn -f maven/pom.xml -Punittests -pl core-unittests test (fails: missing provided dependency com.codenameone:codenameone-factory:8.0-SNAPSHOT in this environment)

Codex Task

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-26T04:54:26Z

Ports/JavaSE/src/com/codename1/impl/javase/JavaSEPort.java

            window.addWindowListener(new WindowListener() {

                public void windowOpened(WindowEvent e) {
+                    fireDesktopWindowEvent(com.codename1.ui.events.WindowEvent.Type.Shown);
                }

                public void windowClosing(WindowEvent e) {


Resolve WindowEvent import ambiguity in JavaSEPort

The new import of com.codename1.ui.events.WindowEvent (line 117) conflicts with the existing import java.awt.event.*;. The existing window listeners still declare their parameters as unqualified WindowEvent (e.g., windowOpened(WindowEvent e) below), which is now ambiguous between the AWT and CN1 types and prevents this file from compiling. Fully qualify the intended AWT type or drop the conflicting import so Java can resolve the symbol.

Useful? React with 👍 / 👎.

shai-almog · 2025-11-26T06:09:39Z

Android screenshot updates

Compared 4 screenshots: 1 matched, 1 updated, 2 missing references.

BrowserComponent — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
GraphicsPipeline — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/GraphicsPipeline.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as GraphicsPipeline.png in workflow artifacts.
GraphicsTransformations — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/GraphicsTransformations.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as GraphicsTransformations.png in workflow artifacts.

Native Android coverage

📊 Line coverage: 17.84% (1920/10763 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 17.44% (8853/50756), branch 9.48% (447/4714), complexity 12.33% (526/4267), method 24.77% (452/1825), class 25.00% (76/304)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/398 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.CodenameOneInputConnection – 0.00% (0/109 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)

shai-almog · 2025-11-26T06:13:49Z

iOS screenshot updates

Compared 6 screenshots: 2 matched, 4 missing references.

GraphicsPipeline — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsPipeline.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsPipeline.png in workflow artifacts.
GraphicsShapesAndGradients — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsShapesAndGradients.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsShapesAndGradients.png in workflow artifacts.
GraphicsTransformations — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/GraphicsTransformations.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as GraphicsTransformations.png in workflow artifacts.
MediaPlayback — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/MediaPlayback.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

github-actions · 2025-11-26T18:05:53Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 1990 total, 0 failed, 0 skipped
📊 Line coverage: 44.65% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.services.RSSService$1 – 0.00%
  - com.codename1.io.services.TwitterRESTService – 0.00%
  - com.codename1.io.services.ImageDownloadService$6 – 0.00%
  - com.codename1.io.services.ImageDownloadService$1 – 0.00%
  - com.codename1.io.services.ImageDownloadService$3 – 0.00%
  - com.codename1.io.services.ImageDownloadService$2 – 0.00%
  - com.codename1.io.services.ImageDownloadService$5 – 0.00%
  - com.codename1.io.services.ImageDownloadService$4 – 0.00%
  - com.codename1.io.services.TwitterRESTService$1 – 0.00%
  - com.codename1.io.services.RSSService – 0.00%

Static Analysis

❌ SpotBugs: 995 findings (High: 92, Normal: 485, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 990 more
❌ PMD: 2727 findings (P2: 1, P3: 649, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 207980 findings (Warning: 207980) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 207975 more

Generated automatically by the PR CI workflow.

Refine desktop window handling

716c9f9

shai-almog added the codex label Nov 26, 2025 — with ChatGPT Codex Connector

chatgpt-codex-connector bot reviewed Nov 26, 2025

View reviewed changes

shai-almog added 3 commits November 26, 2025 07:01

Make window event dispatch thread-safe

7ca8554

Ensure initial window hint is applied and fix window listener import

84e9ad9

Ensure initial window hint applied once and fix desktop event type

410fd53

shai-almog added 2 commits November 26, 2025 17:39

Reinitialize display for each UI unit test

3f2aa85

Apply initial window size hint only when provided

048c489

shai-almog added 4 commits November 26, 2025 20:20

Handle window size hints without Number dependency

383acce

Fix window sizing hint application

7270075

Expose initial window size hint API

9c6147f

Expose initial window size hint setter

081372e

shai-almog merged commit a7dbab5 into master Nov 27, 2025
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refine desktop window handling #4171

Refine desktop window handling #4171

shai-almog commented Nov 26, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Nov 26, 2025

Uh oh!

shai-almog commented Nov 26, 2025 •

edited

Loading

Uh oh!

shai-almog commented Nov 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Refine desktop window handling #4171

Refine desktop window handling #4171

Conversation

shai-almog commented Nov 26, 2025

Summary

Testing

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

shai-almog commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android screenshot updates

Native Android coverage

Uh oh!

shai-almog commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Nov 26, 2025 •

edited

Loading

shai-almog commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading