-
Notifications
You must be signed in to change notification settings - Fork 433
Port samples to unit tests in core-unittests #4208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…niteProgress samples to core-unittests This commit ports the following samples to unit tests under `maven/core-unittests`: - GradientAlphaTest -> GradientAlphaSampleTest - GradientTest -> GradientSampleTest - ImageViewerSample2778 -> ImageViewerSample2778Test - ImageViewerTest2679 -> ImageViewerTest2679Test - InfiniteContainerSafeAreaTest -> InfiniteContainerSafeAreaSampleTest - InfiniteProgressWithMessage -> InfiniteProgressWithMessageSampleTest The tests are adapted to run without external resources/network and use Java 8 syntax. Also updated `maven/core-unittests/pom.xml` to use source/target 1.8 to support lambda expressions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Removed maven-compiler-plugin configuration from pom.xml.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Android screenshot updatesCompared 28 screenshots: 0 matched, 3 updated, 25 missing references.
Native Android coverage
|
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
























































Ported 6 Codename One samples to unit tests in
maven/core-unittests.Changes:
GradientAlphaSampleTest.javaGradientSampleTest.javaImageViewerSample2778Test.javaImageViewerTest2679Test.javaInfiniteContainerSafeAreaSampleTest.javaInfiniteProgressWithMessageSampleTest.javamaven/core-unittests/pom.xmlto set source/target to 1.8.The tests simulate the behavior of the original samples using
UITestBaseandTestCodenameOneImplementation. Network calls and external resources (images) have been mocked or replaced with generated content.PR created automatically by Jules for task 5739007037920194241 started by @shai-almog