Simplify CI screenshot scripts and fix truncated PNG error #4209
Conversation
…tness against truncated PNGs. - Moved Java helper classes (ProcessScreenshots.java, etc.) from `scripts/android/tests` to `scripts/common/java`. - Updated `ProcessScreenshots.java` to include a retry mechanism for `loadPng` to handle "PNG chunk truncated before CRC" errors, which were causing flaky iOS builds. - Extracted common screenshot reporting logic into `scripts/lib/cn1ss.sh` as `cn1ss_process_and_report`. - Updated `scripts/run-android-instrumentation-tests.sh` and `scripts/run-ios-ui-tests.sh` to use the shared Java source location and the new shared reporting function, significantly reducing code duplication. - Default class names for Java helpers are now managed in `cn1ss.sh`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Android screenshot updatesCompared 28 screenshots: 0 matched, 3 updated, 25 missing references.
Native Android coverage
|
…tness against truncated PNGs. - Moved Java helper classes (ProcessScreenshots.java, etc.) from `scripts/android/tests` to `scripts/common/java`. - Updated `ProcessScreenshots.java` to include a retry mechanism for `loadPng` to handle "PNG chunk truncated before CRC" errors, which were causing flaky iOS builds. - Extracted common screenshot reporting logic into `scripts/lib/cn1ss.sh` as `cn1ss_process_and_report`. - Updated `scripts/run-android-instrumentation-tests.sh` and `scripts/run-ios-ui-tests.sh` to use the shared Java source location and the new shared reporting function, significantly reducing code duplication. - Default class names for Java helpers are now managed in `cn1ss.sh`.
iOS screenshot updatesCompared 28 screenshots: 0 matched, 3 updated, 25 missing references.
|
…tness against truncated PNGs. - Moved Java helper classes (ProcessScreenshots.java, etc.) from `scripts/android/tests` to `scripts/common/java`. - Updated `ProcessScreenshots.java` to include a retry mechanism for `loadPng` to handle "PNG chunk truncated before CRC" errors, which were causing flaky iOS builds. - Extracted common screenshot reporting logic into `scripts/lib/cn1ss.sh` as `cn1ss_process_and_report`. - Updated `scripts/run-android-instrumentation-tests.sh` and `scripts/run-ios-ui-tests.sh` to use the shared Java source location and the new shared reporting function, significantly reducing code duplication. - Default class names for Java helpers are now managed in `cn1ss.sh`.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This PR simplifies the CI pipeline for screenshot testing on iOS and Android by deduplicating code and creating a shared reporting function. It also addresses a robustness issue where iOS tests would occasionally fail due to truncated PNG files by adding a retry mechanism in
ProcessScreenshots.java.PR created automatically by Jules for task 14584089043081184116 started by @shai-almog