Refactor output selection into handler methods #4223

shai-almog · 2025-12-11T02:04:48Z

Summary

replace output mode selection if/else with a switch statement
move iOS, clean, and default output generation into dedicated handler methods to shorten the main flow

Testing

not run (not requested)

Codex Task

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-12-11T02:11:29Z

vm/ByteCodeTranslator/src/com/codename1/tools/translator/ByteCodeTranslator.java

+        File cn1Globals = new File(srcRoot, "cn1_globals.h");
+        copy(ByteCodeTranslator.class.getResourceAsStream("/cn1_globals.h"), new FileOutputStream(cn1Globals));
+        if (System.getProperty("INCLUDE_NPE_CHECKS", "false").equals("true")) {
+            replaceInFile(cn1Globals, "//#define CN1_INCLUDE_NPE_CHECKS",  "#define CN1_INCLUDE_NPE_CHECKS");
+        }
+        File xmlvm = new File(srcRoot, "xmlvm.h");
+        copy(ByteCodeTranslator.class.getResourceAsStream("/xmlvm.h"), new FileOutputStream(xmlvm));
+        File nativeMethods = new File(srcRoot, "nativeMethods.m");
+        copy(ByteCodeTranslator.class.getResourceAsStream("/nativeMethods.m"), new FileOutputStream(nativeMethods));


Copy cn1_globals.m for clean output

The new handleCleanOutput() copies cn1_globals.h and nativeMethods.m but never copies cn1_globals.m, even though the generated C code (and nativeMethods.m) rely on implementations defined there such as monitorEnter/GC helpers. The iOS handler still copies both header and .m (lines 293–299), so the clean target now ships only declarations and will fail to link when using the clean output mode.

Useful? React with 👍 / 👎.

github-actions · 2025-12-11T02:15:39Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2078 total, 0 failed, 0 skipped
📊 Line coverage: 47.11% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.services.RSSService$1 – 0.00%
  - com.codename1.io.services.TwitterRESTService – 0.00%
  - com.codename1.io.services.ImageDownloadService$6 – 0.00%
  - com.codename1.io.services.ImageDownloadService$1 – 0.00%
  - com.codename1.io.services.ImageDownloadService$3 – 0.00%
  - com.codename1.io.services.ImageDownloadService$2 – 0.00%
  - com.codename1.io.services.ImageDownloadService$5 – 0.00%
  - com.codename1.io.services.ImageDownloadService$4 – 0.00%
  - com.codename1.io.services.TwitterRESTService$1 – 0.00%
  - com.codename1.io.services.RSSService – 0.00%

Static Analysis

❌ SpotBugs: 995 findings (High: 92, Normal: 485, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 990 more
❌ PMD: 2727 findings (P2: 1, P3: 649, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 213831 findings (Warning: 213831) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 213826 more

Generated automatically by the PR CI workflow.

shai-almog · 2025-12-11T02:43:37Z

iOS screenshot updates

Compared 28 screenshots: 0 matched, 3 updated, 25 missing references.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-affine-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-affine-scale.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-affine-scale.png in workflow artifacts.
graphics-clip — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-clip.png.

Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
Full-resolution PNG saved as graphics-clip.png in workflow artifacts.
graphics-draw-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-arc.png.

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-gradient.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-image-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-image-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-image-rect.png in workflow artifacts.
graphics-draw-line — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-line.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.
graphics-draw-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-rect.png.

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-shape.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-shape.png in workflow artifacts.
graphics-draw-string — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string-decorated.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
graphics-fill-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-arc.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.
graphics-fill-polygon — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-polygon.png.

Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-polygon.png in workflow artifacts.
graphics-fill-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-rect.png in workflow artifacts.
graphics-fill-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.
graphics-fill-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-shape.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-shape.png in workflow artifacts.
graphics-fill-triangle — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-triangle.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-triangle.png in workflow artifacts.
graphics-rotate — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-rotate.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-rotate.png in workflow artifacts.
graphics-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-scale.png.

Preview info: JPEG preview quality 60; JPEG preview quality 60; downscaled to 844x1835.
Full-resolution PNG saved as graphics-scale.png in workflow artifacts.
graphics-stroke-test — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-stroke-test.png.

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 844x1835.
Full-resolution PNG saved as graphics-stroke-test.png in workflow artifacts.
graphics-tile-image — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-tile-image.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-tile-image.png in workflow artifacts.
graphics-transform-camera — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-camera.png.

Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-camera.png in workflow artifacts.
graphics-transform-perspective — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-perspective.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-perspective.png in workflow artifacts.
graphics-transform-rotation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-rotation.png.

Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-rotation.png in workflow artifacts.
graphics-transform-translation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-translation.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-translation.png in workflow artifacts.
MainActivity — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MainActivity.png in workflow artifacts.
MediaPlayback — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.