Add integration coverage for Invoke and Ldc bytecodes #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

shai-almog merged 1 commit into master from codex/expand-bytecodeinstructionintegrationtest-coverage-3imsmc

Dec 12, 2025

Collaborator

shai-almog commented Dec 12, 2025

Summary

factor shared Java lang stub writing to simplify test setup
add a new Invoke/Ldc/locals integration scenario that translates to native code and validates generated instructions
provide minimal runtime stubs for extra translated classes to allow native builds

Testing

mvn -Dtest=BytecodeInstructionIntegrationTest test


          Add integration coverage for Invoke and Ldc bytecodes

76e2d7b

shai-almog added the codex label

— with

ChatGPT Codex Connector

chatgpt-codex-connector bot commented Dec 12, 2025

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

github-actions bot commented Dec 12, 2025

✅ ByteCodeTranslator Quality Report

Test & Coverage

✅ Tests: 13 total, 0 failed, 0 skipped
📊 Line coverage: 59.46% [HTML preview]
- Lowest covered classes
  - com.codename1.tools.translator.ByteCodeTranslator – 23.61%
  - com.codename1.tools.translator.bytecodes.LocalVariable – 25.00%
  - com.codename1.tools.translator.bytecodes.BasicInstruction – 28.93%
  - com.codename1.tools.translator.bytecodes.MultiArray – 34.48%
  - com.codename1.tools.translator.bytecodes.Jump – 36.54%
  - com.codename1.tools.translator.bytecodes.Ldc – 39.79%
  - com.codename1.tools.translator.bytecodes.ArithmeticExpression – 41.76%
  - com.codename1.tools.translator.Util – 43.00%
  - com.codename1.tools.translator.bytecodes.Field – 45.68%
  - com.codename1.tools.translator.ByteCodeTranslator$OutputType$1 – 50.00%

Static Analysis

✅ SpotBugs: no findings (report was not generated by the build).
⚠️ PMD report not generated.
⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

github-actions bot commented Dec 12, 2025

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2127 total, 0 failed, 0 skipped
📊 Line coverage: 48.08% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.spinner.Picker$1$5 – 0.00%
  - com.codename1.ui.spinner.Picker$1$4 – 0.00%
  - com.codename1.ui.spinner.Picker$1$6 – 0.00%
  - com.codename1.ui.spinner.Picker$1$8 – 0.00%
  - com.codename1.ui.spinner.Picker$3$1 – 0.00%
  - com.codename1.ui.spinner.Picker$4$1 – 0.00%
  - com.codename1.media.RemoteControlCallback$3 – 0.00%
  - com.codename1.media.RemoteControlCallback$4 – 0.00%
  - com.codename1.media.RemoteControlCallback$2 – 0.00%
  - com.codename1.media.MediaManager$1$1 – 0.00%

Static Analysis

❌ SpotBugs: 995 findings (High: 92, Normal: 485, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 990 more
❌ PMD: 2727 findings (P2: 1, P3: 649, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 215588 findings (Warning: 215588) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 215583 more

Generated automatically by the PR CI workflow.

Collaborator Author

shai-almog commented Dec 12, 2025 •

edited

Loading

iOS screenshot updates

Compared 28 screenshots: 0 matched, 3 updated, 25 missing references.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-affine-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-affine-scale.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-affine-scale.png in workflow artifacts.
graphics-clip — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-clip.png.

Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
Full-resolution PNG saved as graphics-clip.png in workflow artifacts.
graphics-draw-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-arc.png.

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-gradient.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-image-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-image-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-image-rect.png in workflow artifacts.
graphics-draw-line — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-line.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.
graphics-draw-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-rect.png.

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-shape.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-shape.png in workflow artifacts.
graphics-draw-string — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string-decorated.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
graphics-fill-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-arc.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.
graphics-fill-polygon — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-polygon.png.

Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-polygon.png in workflow artifacts.
graphics-fill-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-rect.png in workflow artifacts.
graphics-fill-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.
graphics-fill-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-shape.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-shape.png in workflow artifacts.
graphics-fill-triangle — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-triangle.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-fill-triangle.png in workflow artifacts.
graphics-rotate — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-rotate.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-rotate.png in workflow artifacts.
graphics-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-scale.png.

Preview info: JPEG preview quality 60; JPEG preview quality 60; downscaled to 844x1835.
Full-resolution PNG saved as graphics-scale.png in workflow artifacts.
graphics-stroke-test — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-stroke-test.png.

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 844x1835.
Full-resolution PNG saved as graphics-stroke-test.png in workflow artifacts.
graphics-tile-image — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-tile-image.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-tile-image.png in workflow artifacts.
graphics-transform-camera — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-camera.png.

Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-camera.png in workflow artifacts.
graphics-transform-perspective — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-perspective.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-perspective.png in workflow artifacts.
graphics-transform-rotation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-rotation.png.

Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-rotation.png in workflow artifacts.
graphics-transform-translation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-translation.png.

Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
Full-resolution PNG saved as graphics-transform-translation.png in workflow artifacts.
MainActivity — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MainActivity.png in workflow artifacts.
MediaPlayback — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

shai-almog merged commit d2e9b86 into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels