Skip to content

Expand BytecodeInstructionIntegrationTest coverage #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 2 commits into from
Dec 12, 2025
Merged

Expand BytecodeInstructionIntegrationTest coverage #4238

shai-almog merged 2 commits into from
Dec 12, 2025

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Dec 12, 2025

Expanded BytecodeInstructionIntegrationTest in vm/tests to cover requested ByteCodeTranslator methods.
Added reflection-based unit tests for private methods and integration tests for output handlers.
Fixed environment issues by adding test resources and handling static state cleanup.
Verified tests pass on Java 21 environment.

PR created automatically by Jules for task 17613635950167170113 started by @shai-almog

@google-labs-jules
Expand BytecodeInstructionIntegrationTest to cover more ByteCodeTrans…
5476f6b 
…lator methods

Added tests for:
- handleDefaultOutput
- readFileAsStringBuilder
- copyDir
- replaceInFile
- getFileType
- handleIosOutput

Updated vm/tests/pom.xml to include ByteCodeTranslator/src as test resource.
Added helper to reset static ByteCodeClass state to fix flaky tests.
Added helper to compile dummy main class for tests.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Dec 12, 2025

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

✅ ByteCodeTranslator Quality Report

Test & Coverage

Static Analysis

  • ✅ SpotBugs: no findings (report was not generated by the build).
  • ⚠️ PMD report not generated.
  • ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog
Copy link
Collaborator

shai-almog commented Dec 12, 2025 •
edited
Loading

iOS screenshot updates

Compared 28 screenshots: 0 matched, 3 updated, 25 missing references.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-affine-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-affine-scale.png.

    graphics-affine-scale
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-affine-scale.png in workflow artifacts.

  • graphics-clip — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-clip.png.

    graphics-clip
    Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-clip.png in workflow artifacts.

  • graphics-draw-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-arc.png.

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-gradient.png.

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-image-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-image-rect.png.

    graphics-draw-image-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-image-rect.png in workflow artifacts.

  • graphics-draw-line — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-line.png.

    graphics-draw-line
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.

  • graphics-draw-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-rect.png.

    graphics-draw-rect
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-shape.png.

    graphics-draw-shape
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-shape.png in workflow artifacts.

  • graphics-draw-string — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string.png.

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string-decorated.png.

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • graphics-fill-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-arc.png.

    graphics-fill-arc
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.

  • graphics-fill-polygon — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-polygon.png.

    graphics-fill-polygon
    Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-polygon.png in workflow artifacts.

  • graphics-fill-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-rect.png.

    graphics-fill-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-rect.png in workflow artifacts.

  • graphics-fill-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-round-rect.png.

    graphics-fill-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.

  • graphics-fill-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-shape.png.

    graphics-fill-shape
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-shape.png in workflow artifacts.

  • graphics-fill-triangle — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-triangle.png.

    graphics-fill-triangle
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-triangle.png in workflow artifacts.

  • graphics-rotate — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-rotate.png.

    graphics-rotate
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-rotate.png in workflow artifacts.

  • graphics-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-scale.png.

    graphics-scale
    Preview info: JPEG preview quality 60; JPEG preview quality 60; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-scale.png in workflow artifacts.

  • graphics-stroke-test — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-stroke-test.png.

    graphics-stroke-test
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-stroke-test.png in workflow artifacts.

  • graphics-tile-image — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-tile-image.png.

    graphics-tile-image
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-tile-image.png in workflow artifacts.

  • graphics-transform-camera — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-camera.png.

    graphics-transform-camera
    Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-camera.png in workflow artifacts.

  • graphics-transform-perspective — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-perspective.png.

    graphics-transform-perspective
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-perspective.png in workflow artifacts.

  • graphics-transform-rotation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-rotation.png.

    graphics-transform-rotation
    Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-rotation.png in workflow artifacts.

  • graphics-transform-translation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-translation.png.

    graphics-transform-translation
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-translation.png in workflow artifacts.

  • MainActivity — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    MainActivity
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as MainActivity.png in workflow artifacts.

  • MediaPlayback — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    MediaPlayback
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

@google-labs-jules
Expand BytecodeInstructionIntegrationTest to cover more ByteCodeTrans…
e028f24 
…lator methods

Added tests for:
- handleDefaultOutput
- readFileAsStringBuilder
- copyDir
- replaceInFile
- getFileType
- handleIosOutput

Updated vm/tests/pom.xml to include ByteCodeTranslator/src as test resource.
Added helper to reset static ByteCodeClass state to fix flaky tests.
Added helper to compile dummy main class for tests.
@shai-almog shai-almog marked this pull request as ready for review December 12, 2025 12:11
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 12, 2025

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@shai-almog shai-almog merged commit ad2537b into master Dec 12, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shai-almog