Skip to content

Fix iOS BrowserComponent screenshot timing issue #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shai-almog merged 4 commits into from
Dec 13, 2025
Merged

Fix iOS BrowserComponent screenshot timing issue #4243

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bf114f
Fix iOS BrowserComponent screenshot test by verifying content via JS …
google-labs-jules[bot] Dec 13, 2025
4d8610d
Refine iOS BrowserComponent screenshot test with immediate polling
google-labs-jules[bot] Dec 13, 2025
35975cf
Fix iOS BrowserComponent screenshot by synchronizing onLoad via JS co…
google-labs-jules[bot] Dec 13, 2025
69f9f80
Fix iOS BrowserComponent screenshot timing issue
google-labs-jules[bot] Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Ports/iOSPort/nativeSources/UIWebViewEventDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ - (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigat
// SUCKS!! WKWebView is out of process so we can't access Javascript context directly anymore.
// So we have to do browser navigation callbacks the old fashioned way.
#endif
com_codename1_impl_ios_IOSImplementation_fireWebViewDidFinishLoad___com_codename1_ui_BrowserComponent_java_lang_String(CN1_THREAD_GET_STATE_PASS_ARG c, xmlvm_create_java_string(CN1_THREAD_GET_STATE_PASS_ARG webView.URL.absoluteString.UTF8String));
[webView evaluateJavaScript:@"document.body.offsetHeight" completionHandler:^(id result, NSError *error) {
com_codename1_impl_ios_IOSImplementation_fireWebViewDidFinishLoad___com_codename1_ui_BrowserComponent_java_lang_String(CN1_THREAD_GET_STATE_PASS_ARG c, xmlvm_create_java_string(CN1_THREAD_GET_STATE_PASS_ARG webView.URL.absoluteString.UTF8String));
}];
}


Expand Down
Loading