-
Notifications
You must be signed in to change notification settings - Fork 433
Fix flaky Android screenshot tests by throttling logcat output #4253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky Android screenshot tests by throttling logcat output #4253
Conversation
Reduced screenshot base64 chunk size from 900 to 500 bytes and added a 20ms delay between chunks. This mitigates logcat buffer overflows on Android, which were causing "PNG chunk truncated before CRC" errors in CI screenshot processing.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Android screenshot updatesCompared 28 screenshots: 0 matched, 3 updated, 25 missing references.
Native Android coverage
|
Conditionally apply logcat throttling (small chunk size and delays) only when running on Android. This preserves the fix for flaky Android screenshot logs while reverting iOS behavior to its original state (larger chunks, no delay) to avoid timeouts. Refactored `Cn1ssDeviceRunnerHelper.java` to use named constants for chunk sizes and delays.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
























































The CI screenshot processing on Android was flaky, failing with "PNG chunk truncated before CRC". This was traced to the
adb logcatbuffer dropping lines when large amounts of base64 data were printed too quickly. This change reduces the chunk size and adds a small delay between prints to allow the buffer to drain.PR created automatically by Jules for task 17365453345066086086 started by @shai-almog