Fix iOS orientation lock immediate rotation #4260
Conversation
Implemented `requestGeometryUpdateWithPreferences:` for iOS 16+ to force immediate orientation change when `lockOrientation` is called. Added `supportedInterfaceOrientations` to `CodenameOne_GLViewController` to properly support orientation locking on iOS 6+. Updated `unlockOrientation` to trigger orientation update.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
iOS screenshot updatesCompared 29 screenshots: 0 matched, 3 updated, 26 missing references.
|
|
Acknowledged. The screenshot indicates that the UI is not rotating to landscape as expected. I suspect that |
Implemented `requestGeometryUpdateWithPreferences:` for iOS 16+ to force immediate orientation change when `lockOrientation` is called. Added `supportedInterfaceOrientations` to `CodenameOne_GLViewController` to properly support orientation locking on iOS 6+. Updated `shouldAutorotate` to return `YES` unconditionally, allowing `supportedInterfaceOrientations` to control the behavior and preventing blocks based on current device orientation. Updated `unlockOrientation` to trigger orientation update.
Implemented `requestGeometryUpdateWithPreferences:` for iOS 16+ to force immediate orientation change when `lockOrientation` is called. Added `supportedInterfaceOrientations` to `CodenameOne_GLViewController` to properly support orientation locking on iOS 6+. Updated `shouldAutorotate` to return `YES` unconditionally, allowing `supportedInterfaceOrientations` to control the behavior and preventing blocks based on current device orientation. Updated `unlockOrientation` to trigger orientation update.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This change fixes an issue where
lockOrientationon iOS would not immediately rotate the UI to the locked orientation, requiring manual rotation by the user.Changes:
Ports/iOSPort/nativeSources/CodenameOne_GLViewController.m:supportedInterfaceOrientationsmethod to return the correctUIInterfaceOrientationMaskbased on theorientationLockstate. This is required for modern iOS orientation handling.Ports/iOSPort/nativeSources/IOSNative.m:lockOrientationto userequestGeometryUpdateWithPreferences:on iOS 16+ to programmatically force orientation changes.setNeedsUpdateOfSupportedInterfaceOrientationson the root view controller.unlockOrientationto also trigger an update of supported orientations, allowing the device to rotate freely again.setValue:forKey:@"orientation"andattemptRotationToDeviceOrientation.PR created automatically by Jules for task 18007294291652271666 started by @shai-almog