-
Notifications
You must be signed in to change notification settings - Fork 433
Fix unit test failures and suppress expected errors in core-unittests #4265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit test failures and suppress expected errors in core-unittests #4265
Conversation
…ogin1) - SQLMap: Fixed a NullPointerException in `SelectBuilder` constructor when `parent` is null, and updated `SQLMapTest` to assert success instead of expecting failure. - SideMenuBar: Added a null check for `parent` in `installMenuBar` to prevent NPEs during initialization or restoration. - Login1Test: Wrapped expected exception generation in `TestLogger` to prevent pollution of the test output console.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Android screenshot updatesCompared 30 screenshots: 0 matched, 3 updated, 27 missing references.
Native Android coverage
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |




























































This submission addresses three issues reported in
maven/core-unittests:SQLMapTest.testSelectBuild: The test was failing because it expected an NPE which wasn't being thrown in some environments, or was revealing an actual bug. The underlying bug inSQLMap.SelectBuilder(accessingparent.childwhenparentis null) was fixed, and the test was updated to verify correct behavior instead of expecting a crash.SideMenuBarTest: An NPE was reported inSideMenuBar.installMenuBar. A guard clause was added to check ifparentis null before proceeding, preventing the crash.Login1Test: The test intentionally throws an exception ("Fail") which was printing stack traces to the console. This block was wrapped withTestLogger.install()/remove()to suppress the expected error output.PR created automatically by Jules for task 7331651936420091061 started by @shai-almog