Removed dead code #4266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

shai-almog merged 1 commit into master from delete-CodenameOneInputConnection

Dec 16, 2025

+0 −240

Collaborator

shai-almog commented Dec 16, 2025

No description provided.


          Removed dead code

8fe19fb

github-actions bot commented Dec 16, 2025

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2232 total, 0 failed, 0 skipped
📊 Line coverage: 52.10% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.properties.SQLMap$SelectBuilder – 0.00%
  - com.codename1.properties.UiBinding$TextComponentAdapter – 0.00%
  - com.codename1.components.RSSReader$BackCommand – 0.00%
  - com.codename1.io.Data$StorageData – 0.00%
  - com.codename1.properties.UiBinding$MappingConverter – 0.00%
  - com.codename1.properties.UiBinding$DateConverter – 0.00%
  - com.codename1.ui.layouts.GroupLayout$SpringDelta – 0.00%
  - com.codename1.util.regex.REUtil – 0.00%
  - com.codename1.components.RSSReader$Listener – 0.00%
  - com.codename1.ui.layouts.mig.LayoutCallback – 0.00%

Static Analysis

❌ SpotBugs: 995 findings (High: 92, Normal: 485, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 990 more
❌ PMD: 2727 findings (P2: 1, P3: 649, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 218622 findings (Warning: 218622) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 218617 more

Generated automatically by the PR CI workflow.

Collaborator Author

shai-almog commented Dec 16, 2025 •

edited

Loading

Android screenshot updates

Compared 30 screenshots: 0 matched, 3 updated, 27 missing references.

BrowserComponent — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
MainActivity — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as MainActivity.png in workflow artifacts.
MediaPlayback — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.
graphics-affine-scale — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-affine-scale.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-affine-scale.png in workflow artifacts.
graphics-clip — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-clip.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-clip.png in workflow artifacts.
graphics-draw-arc — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-arc.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-gradient.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-image-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-image-rect.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-draw-image-rect.png in workflow artifacts.
graphics-draw-line — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-line.png.

Preview info: JPEG preview quality 60; JPEG preview quality 60.
Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.
graphics-draw-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-rect.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-shape — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-shape.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-draw-shape.png in workflow artifacts.
graphics-draw-string — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-string.png.

Preview info: JPEG preview quality 50; JPEG preview quality 50.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-string-decorated.png.

Preview info: JPEG preview quality 60; JPEG preview quality 60.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
graphics-fill-arc — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-arc.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.
graphics-fill-polygon — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-polygon.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-fill-polygon.png in workflow artifacts.
graphics-fill-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-rect.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-fill-rect.png in workflow artifacts.
graphics-fill-round-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-round-rect.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.
graphics-fill-shape — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-shape.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-fill-shape.png in workflow artifacts.
graphics-fill-triangle — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-triangle.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-fill-triangle.png in workflow artifacts.
graphics-rotate — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-rotate.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-rotate.png in workflow artifacts.
graphics-scale — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-scale.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-scale.png in workflow artifacts.
graphics-stroke-test — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-stroke-test.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-stroke-test.png in workflow artifacts.
graphics-tile-image — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-tile-image.png.

Preview info: JPEG preview quality 20; JPEG preview quality 20.
Full-resolution PNG saved as graphics-tile-image.png in workflow artifacts.
graphics-transform-camera — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-camera.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-transform-camera.png in workflow artifacts.
graphics-transform-perspective — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-perspective.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-transform-perspective.png in workflow artifacts.
graphics-transform-rotation — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-rotation.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-transform-rotation.png in workflow artifacts.
graphics-transform-translation — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-translation.png.

Preview info: JPEG preview quality 70; JPEG preview quality 70.
Full-resolution PNG saved as graphics-transform-translation.png in workflow artifacts.
kotlin — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/kotlin.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.
landscape — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/landscape.png.

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as landscape.png in workflow artifacts.

Native Android coverage

📊 Line coverage: 24.90% (2656/10665 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.52% (12338/50325), branch 15.38% (713/4636), complexity 17.45% (736/4218), method 32.73% (594/1815), class 34.65% (105/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/398 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

shai-almog merged commit 41895d5 into master

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet