Migrate VM projects to Maven #4269
Conversation
- Created POM files for `vm` directory projects (`ByteCodeTranslator`, `JavaAPI`, `tests`). - Configured Maven build to use source/target 1.5 and ASM 5.0.3 to maintain legacy semantics. - Added `maven-antrun-plugin` to copy build artifacts to `dist/` directory for compatibility. - Updated GitHub Actions workflow `pr.yml` to build VM projects using Maven instead of Ant. - Ensured test source files remain unchanged.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
iOS screenshot updatesCompared 30 screenshots: 0 matched, 3 updated, 27 missing references.
|
- Created Maven POM files for `vm` (parent), `ByteCodeTranslator`, `JavaAPI`, and `tests`. - Configured parent POM to use `maven-compiler-plugin` with source/target 1.5 and ASM 5.0.3, strictly preserving legacy semantics. - Updated `vm/tests/pom.xml` to use source/target 1.8 for test execution (JUnit 5 support) while testing JDK 1.5 artifacts. - Added `maven-antrun-plugin` to `ByteCodeTranslator` and `JavaAPI` to copy generated JARs to the legacy `dist/` directory for backward compatibility with external scripts. - Updated `.github/workflows/pr.yml` to replace Ant build commands with Maven commands for VM projects and updated artifact paths to `target/`. - Updated `.github/workflows/parparvm-tests.yml` to run Maven from the `vm` directory (reactor root) to correctly resolve module dependencies. - Reverted test source modifications to ensure no Java source files are changed.
✅ ByteCodeTranslator Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This PR migrates the build system for the projects under the
vmdirectory (ByteCodeTranslator,JavaAPI, andtests) from Ant to Maven.Key changes:
pom.xmlinvm/and childpom.xmlfiles for each project.ByteCodeTranslatorto usemaven-shade-pluginfor packaging dependencies.maven-antrun-pluginexecution to copy the resulting JARs todist/directories, ensuring backward compatibility with any existing scripts or tools that expect artifacts in that location..github/workflows/pr.ymlto usemvn packageinstead ofant jarfor the VM projects and updated artifact upload paths to point to the Maventarget/directory.CleanTargetIntegrationTest.java,BytecodeInstructionIntegrationTest.java) to ensure the source code remains untouched.This change allows the VM projects to be built using standard Maven commands while preserving the exact bytecode semantics required by the project. The CI workflow is updated to verify this using the appropriate JDK environment (JDK 8).
PR created automatically by Jules for task 8039737932530094563 started by @shai-almog