-
Notifications
You must be signed in to change notification settings - Fork 433
Update ASM to 9.2 in ByteCodeTranslator and ParparVM #4271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated `asm` dependencies in `vm/pom.xml` and `maven/parparvm/pom.xml` to 9.2. Updated `vm/ByteCodeTranslator/src/com/codename1/tools/translator/Parser.java` to use `Opcodes.ASM9`. This change maintains source/target 1.5 compatibility in configuration while enabling support for newer class file features.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ ByteCodeTranslator Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Android screenshot updatesCompared 30 screenshots: 0 matched, 3 updated, 27 missing references.
Native Android coverage
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |




























































Updated ASM version to 9.2 in both
vmandmaven/parparvmdirectories.Modified
Parser.javato useOpcodes.ASM9.Verified compilation with ASM 9.2 (using temporary 1.8 source/target for verification due to environment JDK version).
Ensured
vm/pom.xmlretains 1.5 source/target compatibility.PR created automatically by Jules for task 5849477082489453938 started by @shai-almog