Skip to content

Revert "Add Contacts, Video, and Socket tests to hellocodenameone" #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shai-almog merged 1 commit into from
Dec 16, 2025
Merged

Revert "Add Contacts, Video, and Socket tests to hellocodenameone" #4272

shai-almog merged 1 commit into from
Dec 16, 2025

Conversation

@shai-almog
Copy link
Collaborator

@shai-almog shai-almog commented Dec 16, 2025

Reverts #4267

@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Dec 16, 2025

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@shai-almog shai-almog merged commit 8cc7520 into master Dec 16, 2025
7 checks passed
@shai-almog
Copy link
Collaborator Author

shai-almog commented Dec 16, 2025 •
edited
Loading

Android screenshot updates

Compared 30 screenshots: 0 matched, 3 updated, 27 missing references.

  • BrowserComponent — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

    BrowserComponent
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • MainActivity — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

    MainActivity
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as MainActivity.png in workflow artifacts.

  • MediaPlayback — updated screenshot. Screenshot differs (320x616 px, bit depth 8).

    MediaPlayback
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

  • graphics-affine-scale — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-affine-scale.png.

    graphics-affine-scale
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-affine-scale.png in workflow artifacts.

  • graphics-clip — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-clip.png.

    graphics-clip
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-clip.png in workflow artifacts.

  • graphics-draw-arc — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-arc.png.

    graphics-draw-arc
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-gradient.png.

    graphics-draw-gradient
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-image-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-image-rect.png.

    graphics-draw-image-rect
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-draw-image-rect.png in workflow artifacts.

  • graphics-draw-line — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-line.png.

    graphics-draw-line
    Preview info: JPEG preview quality 60; JPEG preview quality 60.
    Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.

  • graphics-draw-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-rect.png.

    graphics-draw-rect
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-shape — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-shape.png.

    graphics-draw-shape
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-draw-shape.png in workflow artifacts.

  • graphics-draw-string — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-string.png.

    graphics-draw-string
    Preview info: JPEG preview quality 50; JPEG preview quality 50.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-draw-string-decorated.png.

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 60; JPEG preview quality 60.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • graphics-fill-arc — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-arc.png.

    graphics-fill-arc
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.

  • graphics-fill-polygon — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-polygon.png.

    graphics-fill-polygon
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-fill-polygon.png in workflow artifacts.

  • graphics-fill-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-rect.png.

    graphics-fill-rect
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-fill-rect.png in workflow artifacts.

  • graphics-fill-round-rect — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-round-rect.png.

    graphics-fill-round-rect
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.

  • graphics-fill-shape — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-shape.png.

    graphics-fill-shape
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-fill-shape.png in workflow artifacts.

  • graphics-fill-triangle — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-fill-triangle.png.

    graphics-fill-triangle
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-fill-triangle.png in workflow artifacts.

  • graphics-rotate — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-rotate.png.

    graphics-rotate
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-rotate.png in workflow artifacts.

  • graphics-scale — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-scale.png.

    graphics-scale
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-scale.png in workflow artifacts.

  • graphics-stroke-test — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-stroke-test.png.

    graphics-stroke-test
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-stroke-test.png in workflow artifacts.

  • graphics-tile-image — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-tile-image.png.

    graphics-tile-image
    Preview info: JPEG preview quality 20; JPEG preview quality 20.
    Full-resolution PNG saved as graphics-tile-image.png in workflow artifacts.

  • graphics-transform-camera — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-camera.png.

    graphics-transform-camera
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-transform-camera.png in workflow artifacts.

  • graphics-transform-perspective — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-perspective.png.

    graphics-transform-perspective
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-transform-perspective.png in workflow artifacts.

  • graphics-transform-rotation — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-rotation.png.

    graphics-transform-rotation
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-transform-rotation.png in workflow artifacts.

  • graphics-transform-translation — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/graphics-transform-translation.png.

    graphics-transform-translation
    Preview info: JPEG preview quality 70; JPEG preview quality 70.
    Full-resolution PNG saved as graphics-transform-translation.png in workflow artifacts.

  • kotlin — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/kotlin.png.

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

  • landscape — missing reference. Reference screenshot missing at /home/runner/work/CodenameOne/CodenameOne/scripts/android/screenshots/landscape.png.

    landscape
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as landscape.png in workflow artifacts.

Native Android coverage

  • 📊 Line coverage: 24.97% (2663/10665 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.55% (12353/50325), branch 15.36% (712/4636), complexity 17.45% (736/4218), method 32.84% (596/1815), class 34.98% (106/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/398 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

@shai-almog
Copy link
Collaborator Author

shai-almog commented Dec 16, 2025 •
edited
Loading

iOS screenshot updates

Compared 30 screenshots: 0 matched, 3 updated, 27 missing references.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-affine-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-affine-scale.png.

    graphics-affine-scale
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-affine-scale.png in workflow artifacts.

  • graphics-clip — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-clip.png.

    graphics-clip
    Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-clip.png in workflow artifacts.

  • graphics-draw-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-arc.png.

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-gradient.png.

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-image-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-image-rect.png.

    graphics-draw-image-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-image-rect.png in workflow artifacts.

  • graphics-draw-line — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-line.png.

    graphics-draw-line
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-line.png in workflow artifacts.

  • graphics-draw-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-rect.png.

    graphics-draw-rect
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-rect.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-shape.png.

    graphics-draw-shape
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-shape.png in workflow artifacts.

  • graphics-draw-string — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string.png.

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-string-decorated.png.

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • graphics-fill-arc — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-arc.png.

    graphics-fill-arc
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-arc.png in workflow artifacts.

  • graphics-fill-polygon — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-polygon.png.

    graphics-fill-polygon
    Preview info: JPEG preview quality 30; JPEG preview quality 30; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-polygon.png in workflow artifacts.

  • graphics-fill-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-rect.png.

    graphics-fill-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-rect.png in workflow artifacts.

  • graphics-fill-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-round-rect.png.

    graphics-fill-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-round-rect.png in workflow artifacts.

  • graphics-fill-shape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-shape.png.

    graphics-fill-shape
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-shape.png in workflow artifacts.

  • graphics-fill-triangle — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-fill-triangle.png.

    graphics-fill-triangle
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-fill-triangle.png in workflow artifacts.

  • graphics-rotate — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-rotate.png.

    graphics-rotate
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-rotate.png in workflow artifacts.

  • graphics-scale — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-scale.png.

    graphics-scale
    Preview info: JPEG preview quality 60; JPEG preview quality 60; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-scale.png in workflow artifacts.

  • graphics-stroke-test — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-stroke-test.png.

    graphics-stroke-test
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-stroke-test.png in workflow artifacts.

  • graphics-tile-image — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-tile-image.png.

    graphics-tile-image
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-tile-image.png in workflow artifacts.

  • graphics-transform-camera — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-camera.png.

    graphics-transform-camera
    Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-camera.png in workflow artifacts.

  • graphics-transform-perspective — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-perspective.png.

    graphics-transform-perspective
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-perspective.png in workflow artifacts.

  • graphics-transform-rotation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-rotation.png.

    graphics-transform-rotation
    Preview info: JPEG preview quality 50; JPEG preview quality 50; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-rotation.png in workflow artifacts.

  • graphics-transform-translation — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-transform-translation.png.

    graphics-transform-translation
    Preview info: JPEG preview quality 40; JPEG preview quality 40; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-transform-translation.png in workflow artifacts.

  • kotlin — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/kotlin.png.

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

  • landscape — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/landscape.png.

    landscape
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as landscape.png in workflow artifacts.

  • MainActivity — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    MainActivity
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as MainActivity.png in workflow artifacts.

  • MediaPlayback — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    MediaPlayback
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as MediaPlayback.png in workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shai-almog