Fix iOS gradient rendering issues #4281
Conversation
Fixed gradient drawing in iOS native port to use correct vertex sizes and texture coordinates, preventing overlap and incorrect scaling. Corrected swapped logic for horizontal and vertical gradient directions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
iOS screenshot updatesCompared 30 screenshots: 27 matched, 2 updated, 1 missing reference.
|
- Fixed `DrawGradient.m` (OpenGL):
- Corrected vertex sizes to use requested width/height instead of power-of-two texture dimensions to prevent overflow/overlap.
- Implemented correct texture coordinate mapping (`maxS`, `maxT`) to avoid including padding.
- Updated vertex array logic to use `GL_FLOAT` for texture coordinates.
- Swapped logic for `GRADIENT_TYPE_HORIZONTAL` and `GRADIENT_TYPE_VERTICAL` to match standard coordinate system orientation.
- Fixed `IOSNative.m` (Mutable Images/CoreGraphics):
- Updated `fillRectRadialGradientMutable` to respect the `x` and `y` arguments for both the fill rect and the radial gradient center point, preventing it from always drawing at (0,0).
- Fixed `DrawGradient.m` (OpenGL):
- Corrected vertex sizes to use requested width/height instead of power-of-two texture dimensions to prevent overflow/overlap.
- Implemented correct texture coordinate mapping (`maxS`, `maxT`) to avoid including padding.
- Updated vertex array logic to use `GL_FLOAT` for texture coordinates.
- Swapped logic for `GRADIENT_TYPE_HORIZONTAL` and `GRADIENT_TYPE_VERTICAL` to match standard coordinate system orientation.
- Fixed `IOSNative.m` (Mutable Images/CoreGraphics):
- Updated `fillRectRadialGradientMutable` to respect the `x` and `y` arguments for both the fill rect and the radial gradient center point, preventing it from always drawing at (0,0).
- Added proper clipping (`CGContextClipToRect`) to `fillRectRadialGradientMutable` to prevent gradients from bleeding outside their bounds.
- Added missing `CGGradientRelease` to fix a memory leak.
- Properly wrapped drawing calls in `CGContextSaveGState`/`CGContextRestoreGState` to isolate state changes.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The
DrawGradient.mimplementation on iOS previously rendered gradients using a full power-of-two (POT) quad, which caused the gradient to spill over the requested bounds and overlap neighboring elements. It also used full 0-1 texture coordinates, mapping the entire POT texture (including empty padding) to the quad.This change:
widthandheightinstead ofp2w/p2h.maxSandmaxTtexture coordinates based on the ratio of content size to texture size.GLfloatand maps the quad vertices to the valid content region(0,0)to(maxS, maxT).glVertexAttribPointerto useGL_FLOATfor texture coordinates.GRADIENT_TYPE_HORIZONTALandGRADIENT_TYPE_VERTICALcases where the coordinate logic was swapped (Horizontal now varies X, Vertical varies Y).PR created automatically by Jules for task 6231960715145144739 started by @shai-almog