Skip to content

Update ParparVM CI to test on multiple JDKs (11, 17, 21, 25) #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shai-almog merged 3 commits into from
Dec 17, 2025
+327 −124
Merged

Update ParparVM CI to test on multiple JDKs (11, 17, 21, 25) #4285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1367324
Update ParparVM CI to test on JDK 11, 17, 21, and 25
google-labs-jules[bot] Dec 16, 2025
5bd668f
Update ParparVM tests to run against multiple JDKs and targets
google-labs-jules[bot] Dec 16, 2025
6f37ce9
Update ParparVM CI to test cross-compilation on JDKs 8-25
google-labs-jules[bot] Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 54 additions & 6 deletions .github/workflows/parparvm-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,69 @@ jobs:
- name: Check out repository
uses: actions/checkout@v4

- name: Install native build tools
run: |
sudo apt-get update
sudo apt-get install -y clang

# Install JDKs and export their paths
- name: Set up JDK 8
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '8'
cache: 'maven'
- name: Save JDK 8 Path
run: echo "JDK_8_HOME=$JAVA_HOME" >> $GITHUB_ENV

- name: Install native build tools
run: |
sudo apt-get update
sudo apt-get install -y clang
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '11'
- name: Save JDK 11 Path
run: echo "JDK_11_HOME=$JAVA_HOME" >> $GITHUB_ENV

- name: Set up JDK 17
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '17'
- name: Save JDK 17 Path
run: echo "JDK_17_HOME=$JAVA_HOME" >> $GITHUB_ENV

- name: Set up JDK 21
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '21'
- name: Save JDK 21 Path
run: echo "JDK_21_HOME=$JAVA_HOME" >> $GITHUB_ENV

- name: Set up JDK 25
uses: actions/setup-java@v4
with:
distribution: 'zulu'
java-version: '25'
- name: Save JDK 25 Path
run: echo "JDK_25_HOME=$JAVA_HOME" >> $GITHUB_ENV

# Restore JDK 8 as the main runner
- name: Restore JDK 8
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '8'
cache: 'maven'

- name: Run ParparVM JVM tests
working-directory: vm
run: mvn -B test
run: mvn -B clean test -pl tests -am
env:
JDK_8_HOME: ${{ env.JDK_8_HOME }}
JDK_11_HOME: ${{ env.JDK_11_HOME }}
JDK_17_HOME: ${{ env.JDK_17_HOME }}
JDK_21_HOME: ${{ env.JDK_21_HOME }}
JDK_25_HOME: ${{ env.JDK_25_HOME }}

- name: Publish ByteCodeTranslator quality previews
if: ${{ always() && github.server_url == 'https://github.com' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) }}
Expand Down
2 changes: 1 addition & 1 deletion vm/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<asm.version>9.2</asm.version>
<asm.version>9.8</asm.version>
<junit.jupiter.version>5.10.2</junit.jupiter.version>
</properties>

Expand Down
169 changes: 91 additions & 78 deletions ...ests/src/test/java/com/codename1/tools/translator/BytecodeInstructionIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,20 @@

class BytecodeInstructionIntegrationTest {

static Stream<CompilerHelper.CompilerConfig> provideCompilerConfigs() {
List<CompilerHelper.CompilerConfig> configs = new ArrayList<>();
configs.addAll(CompilerHelper.getAvailableCompilers("1.5"));
configs.addAll(CompilerHelper.getAvailableCompilers("1.8"));
configs.addAll(CompilerHelper.getAvailableCompilers("11"));
configs.addAll(CompilerHelper.getAvailableCompilers("17"));
configs.addAll(CompilerHelper.getAvailableCompilers("21"));
configs.addAll(CompilerHelper.getAvailableCompilers("25"));
return configs.stream();
}

@ParameterizedTest
@ValueSource(strings = {"1.5", "1.8"})
void translatesOptimizedBytecodeToLLVMExecutable(String targetVersion) throws Exception {
if ("1.5".equals(targetVersion) && !isSourceVersionSupported("1.5")) {
return; // Skip on newer JDKs that dropped 1.5 support
}
@org.junit.jupiter.params.provider.MethodSource("provideCompilerConfigs")
void translatesOptimizedBytecodeToLLVMExecutable(CompilerHelper.CompilerConfig config) throws Exception {
Parser.cleanup();

Path sourceDir = Files.createTempDirectory("bytecode-integration-sources");
Expand All @@ -61,28 +69,43 @@ void translatesOptimizedBytecodeToLLVMExecutable(String targetVersion) throws Ex
Path nativeReport = sourceDir.resolve("native_report.c");
Files.write(nativeReport, nativeReportSource().getBytes(StandardCharsets.UTF_8));

JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
assertNotNull(compiler, "A JDK is required to compile test sources");

// Compile App using JavaAPI as bootclasspath
// Compile App using the specific JDK
List<String> compileArgs = new ArrayList<>();
compileArgs.add("-source");
compileArgs.add(targetVersion);
compileArgs.add("-target");
compileArgs.add(targetVersion);
compileArgs.add("-bootclasspath");
compileArgs.add(javaApiDir.toString());

double targetVer = 1.8;
try { targetVer = Double.parseDouble(config.targetVersion); } catch (NumberFormatException ignored) {}

double jdkVer = 1.8;
try { jdkVer = Double.parseDouble(config.jdkVersion); } catch (NumberFormatException ignored) {}

if (jdkVer >= 9) {
compileArgs.add("-source");
compileArgs.add(config.targetVersion);
compileArgs.add("-target");
compileArgs.add(config.targetVersion);
// On JDK 9+, -bootclasspath is removed.
// --patch-module is not allowed with -target 8.
// We rely on the JDK's own bootstrap classes but include our JavaAPI in classpath
// so that any non-replaced classes are found.
// This means we compile against JDK 9+ API but emit older bytecode.
compileArgs.add("-classpath");
compileArgs.add(javaApiDir.toString());
} else {
compileArgs.add("-source");
compileArgs.add(config.targetVersion);
compileArgs.add("-target");
compileArgs.add(config.targetVersion);
compileArgs.add("-bootclasspath");
compileArgs.add(javaApiDir.toString());
compileArgs.add("-Xlint:-options");
}

compileArgs.add("-d");
compileArgs.add(classesDir.toString());
compileArgs.add(sourceDir.resolve("BytecodeInstructionApp.java").toString());

int compileResult = compiler.run(
null,
null,
null,
compileArgs.toArray(new String[0])
);
assertEquals(0, compileResult, "BytecodeInstructionApp should compile");
int compileResult = CompilerHelper.compile(config.jdkHome, compileArgs);
assertEquals(0, compileResult, "BytecodeInstructionApp should compile with " + config);

Files.copy(nativeReport, classesDir.resolve("native_report.c"));

Expand Down Expand Up @@ -190,11 +213,8 @@ private String invokeLdcLocalVarsAppSource() {
}

@ParameterizedTest
@ValueSource(strings = {"1.5", "1.8"})
void translatesInvokeAndLdcBytecodeToLLVMExecutable(String targetVersion) throws Exception {
if ("1.5".equals(targetVersion) && !isSourceVersionSupported("1.5")) {
return; // Skip on newer JDKs that dropped 1.5 support
}
@org.junit.jupiter.params.provider.MethodSource("provideCompilerConfigs")
void translatesInvokeAndLdcBytecodeToLLVMExecutable(CompilerHelper.CompilerConfig config) throws Exception {
Parser.cleanup();

Path sourceDir = Files.createTempDirectory("invoke-ldc-sources");
Expand All @@ -209,27 +229,37 @@ void translatesInvokeAndLdcBytecodeToLLVMExecutable(String targetVersion) throws
Path nativeReport = sourceDir.resolve("native_report.c");
Files.write(nativeReport, nativeReportSource().getBytes(StandardCharsets.UTF_8));

JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
assertNotNull(compiler, "A JDK is required to compile test sources");

List<String> compileArgs = new ArrayList<>();
compileArgs.add("-source");
compileArgs.add(targetVersion);
compileArgs.add("-target");
compileArgs.add(targetVersion);
compileArgs.add("-bootclasspath");
compileArgs.add(javaApiDir.toString());

double targetVer = 1.8;
try { targetVer = Double.parseDouble(config.targetVersion); } catch (NumberFormatException ignored) {}

double jdkVer = 1.8;
try { jdkVer = Double.parseDouble(config.jdkVersion); } catch (NumberFormatException ignored) {}

if (jdkVer >= 9) {
compileArgs.add("-source");
compileArgs.add(config.targetVersion);
compileArgs.add("-target");
compileArgs.add(config.targetVersion);
compileArgs.add("-classpath");
compileArgs.add(javaApiDir.toString());
} else {
compileArgs.add("-source");
compileArgs.add(config.targetVersion);
compileArgs.add("-target");
compileArgs.add(config.targetVersion);
compileArgs.add("-bootclasspath");
compileArgs.add(javaApiDir.toString());
compileArgs.add("-Xlint:-options");
}

compileArgs.add("-d");
compileArgs.add(classesDir.toString());
compileArgs.add(sourceDir.resolve("InvokeLdcLocalVarsApp.java").toString());

int compileResult = compiler.run(
null,
null,
null,
compileArgs.toArray(new String[0])
);
assertEquals(0, compileResult, "InvokeLdcLocalVarsApp should compile");
int compileResult = CompilerHelper.compile(config.jdkHome, compileArgs);
assertEquals(0, compileResult, "InvokeLdcLocalVarsApp should compile with " + config);

Files.copy(nativeReport, classesDir.resolve("native_report.c"));

Expand Down Expand Up @@ -985,18 +1015,15 @@ private String nativeReportSource() {
}

@ParameterizedTest
@ValueSource(strings = {"1.5", "1.8"})
void handleDefaultOutputWritesOutput(String targetVersion) throws Exception {
if ("1.5".equals(targetVersion) && !isSourceVersionSupported("1.5")) {
return; // Skip on newer JDKs that dropped 1.5 support
}
@org.junit.jupiter.params.provider.MethodSource("provideCompilerConfigs")
void handleDefaultOutputWritesOutput(CompilerHelper.CompilerConfig config) throws Exception {
Parser.cleanup();
resetByteCodeClass();
Path sourceDir = Files.createTempDirectory("default-output-source");
Path outputDir = Files.createTempDirectory("default-output-dest");

Files.write(sourceDir.resolve("resource.txt"), "data".getBytes(StandardCharsets.UTF_8));
compileDummyMainClass(sourceDir, "com.example", "MyAppDefault", targetVersion);
compileDummyMainClass(sourceDir, "com.example", "MyAppDefault", config);

String[] args = new String[] {
"csharp",
Expand Down Expand Up @@ -1076,18 +1103,15 @@ void copyDirRecursivelyCopies() throws Exception {
}

@ParameterizedTest
@ValueSource(strings = {"1.5", "1.8"})
void handleIosOutputGeneratesProjectStructure(String targetVersion) throws Exception {
if ("1.5".equals(targetVersion) && !isSourceVersionSupported("1.5")) {
return; // Skip on newer JDKs that dropped 1.5 support
}
@org.junit.jupiter.params.provider.MethodSource("provideCompilerConfigs")
void handleIosOutputGeneratesProjectStructure(CompilerHelper.CompilerConfig config) throws Exception {
Parser.cleanup();
resetByteCodeClass();
Path sourceDir = Files.createTempDirectory("ios-output-source");
Path outputDir = Files.createTempDirectory("ios-output-dest");

Files.write(sourceDir.resolve("resource.txt"), "data".getBytes(StandardCharsets.UTF_8));
compileDummyMainClass(sourceDir, "com.example", "MyAppIOS", targetVersion);
compileDummyMainClass(sourceDir, "com.example", "MyAppIOS", config);

// Add a bundle to test copyDir invocation in execute loop
Path bundleDir = sourceDir.resolve("test.bundle");
Expand Down Expand Up @@ -1139,7 +1163,7 @@ private void resetByteCodeClass() throws Exception {
((Set<?>) writableFieldsField.get(null)).clear();
}

private void compileDummyMainClass(Path sourceDir, String packageName, String className, String targetVersion) throws Exception {
private void compileDummyMainClass(Path sourceDir, String packageName, String className, CompilerHelper.CompilerConfig config) throws Exception {
Path packageDir = sourceDir;
for (String part : packageName.split("\\.")) {
packageDir = packageDir.resolve(part);
Expand All @@ -1152,13 +1176,17 @@ private void compileDummyMainClass(Path sourceDir, String packageName, String cl
"}\n";
Files.write(javaFile, content.getBytes(StandardCharsets.UTF_8));

JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
int result = compiler.run(null, null, null,
"-source", targetVersion,
"-target", targetVersion,
"-d", sourceDir.toString(),
javaFile.toString());
assertEquals(0, result, "Compilation failed");
List<String> args = new ArrayList<>();
args.add("-source");
args.add(config.targetVersion);
args.add("-target");
args.add(config.targetVersion);
args.add("-d");
args.add(sourceDir.toString());
args.add(javaFile.toString());

int result = CompilerHelper.compile(config.jdkHome, args);
assertEquals(0, result, "Compilation failed with " + config);
}

@Test
Expand Down Expand Up @@ -1262,19 +1290,4 @@ void testArithmeticExpressionCoverage() {
// or mock if possible. But here we can check basic behavior.
}

private boolean isSourceVersionSupported(String version) {
String javaVersion = System.getProperty("java.specification.version");
if (javaVersion.startsWith("1.")) {
return true;
}
try {
int major = Integer.parseInt(javaVersion);
if ("1.5".equals(version)) {
if (major >= 9) return false;
}
} catch (NumberFormatException e) {
return true;
}
return true;
}
}
Loading
Loading