Optimizing bytecode translator

[shai-almog]

No description provided.

[github-actions]

✅ ByteCodeTranslator Quality Report

Test & Coverage

• ✅ Tests: 103 total, 0 failed, 0 skipped

Benchmark Results

• Execution Time: 16422 ms

• Hotspots (Top 20 sampled methods):

  • 42.29% com.codename1.tools.translator.Parser.isMethodUsed (1273 samples)
  • 13.12% java.lang.String.indexOf (395 samples)
  • 8.84% com.codename1.tools.translator.Parser.addToConstantPool (266 samples)
  • 6.64% java.util.Hashtable.get (200 samples)
  • 5.81% java.util.ArrayList.indexOf (175 samples)
  • 3.16% java.lang.Object.hashCode (95 samples)
  • 2.16% com.codename1.tools.translator.BytecodeMethod.optimize (65 samples)
  • 2.16% com.codename1.tools.translator.ByteCodeClass.fillVirtualMethodTable (65 samples)
  • 1.83% java.util.HashMap.putVal (55 samples)
  • 1.03% com.codename1.tools.translator.Parser.cullMethods (31 samples)
  • 0.96% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (29 samples)
  • 0.70% java.io.FileOutputStream.open0 (21 samples)
  • 0.70% java.lang.StringBuilder.append (21 samples)
  • 0.66% com.codename1.tools.translator.BytecodeMethod.equals (20 samples)
  • 0.56% java.io.FileOutputStream.writeBytes (17 samples)
  • 0.53% java.lang.System.identityHashCode (16 samples)
  • 0.50% com.codename1.tools.translator.Parser.getClassByName (15 samples)
  • 0.43% java.lang.Integer.getChars (13 samples)
  • 0.37% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (11 samples)
  • 0.33% com.codename1.tools.translator.MultipleSignatureSet.containsSignature (10 samples)

• ⚠️ Coverage report not generated.

Static Analysis

• ✅ SpotBugs: no findings (report was not generated by the build).
• ⚠️ PMD report not generated.
• ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2276 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.89% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.processing.TextEvaluator – 3.45%
    • com.codename1.charts.views.PieChart – 4.00%
    • com.codename1.charts.views.PieMapper – 4.88%
    • com.codename1.charts.views.ScatterChart – 5.32%
    • com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
    • com.codename1.ui.Display$EdtException – 5.56%
    • com.codename1.testing.AbstractTest – 6.05%
    • com.codename1.ui.Transform$ImmutableTransform – 6.06%
    • com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

• ❌ SpotBugs: 992 findings (High: 90, Normal: 484, Low: 418) [HTML preview] [Download]
  • Top findings
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
    • High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
    • …and 987 more
• ❌ PMD: 2728 findings (P2: 1, P3: 650, P4: 2077) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
    • P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • …and 2723 more
• ❌ Checkstyle: 219752 findings (Warning: 219752) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 219747 more

Generated automatically by the PR CI workflow.

[shai-almog]

iOS screenshot updates

Compared 30 screenshots: 24 matched, 5 updated, 1 missing reference.

• BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

• graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

• graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
  Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

• graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
  Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

• graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
  Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

• kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

  
  Preview info: Preview provided by instrumentation.
  Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

• VM Translation Time: 290 seconds
• Compilation Time: 59 seconds