Stabilize BytecodeMethod registration and equality #4307

shai-almog · 2025-12-18T19:13:35Z

Summary

register BytecodeMethod instances with the dependency graph only after descriptor parsing completes
guard BytecodeMethod equality and hashing against null inputs and uninitialized return types to prevent constructor-time errors

Testing

mvn -pl ByteCodeTranslator -am install -DskipTests
mvn -pl tests -Dtest=HeavyLoadBenchmarkTest test (fails: JavaAPI.jar not found at vm/tests/vm/JavaAPI/dist/JavaAPI.jar)

Codex Task

github-actions · 2025-12-18T19:16:23Z

✅ ByteCodeTranslator Quality Report

Test & Coverage

✅ Tests: 103 total, 0 failed, 0 skipped

Benchmark Results

Execution Time: 8808 ms
Hotspots (Top 20 sampled methods):
- 25.75% java.lang.String.indexOf (393 samples)
- 19.20% com.codename1.tools.translator.Parser.isMethodUsed (293 samples)
- 10.62% java.util.ArrayList.indexOf (162 samples)
- 5.50% java.lang.Object.hashCode (84 samples)
- 4.72% com.codename1.tools.translator.ByteCodeClass.markDependent (72 samples)
- 3.80% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (58 samples)
- 3.54% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (54 samples)
- 2.95% java.lang.System.identityHashCode (45 samples)
- 2.10% com.codename1.tools.translator.Parser.addToConstantPool (32 samples)
- 1.97% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (30 samples)
- 1.83% com.codename1.tools.translator.BytecodeMethod.optimize (28 samples)
- 1.38% com.codename1.tools.translator.BytecodeMethod.equals (21 samples)
- 1.38% java.lang.StringBuilder.append (21 samples)
- 1.18% com.codename1.tools.translator.Parser.cullMethods (18 samples)
- 0.92% com.codename1.tools.translator.BytecodeMethod.appendMethodC (14 samples)
- 0.66% java.io.FileInputStream.open0 (10 samples)
- 0.59% java.util.TreeMap.getEntry (9 samples)
- 0.59% java.io.FileOutputStream.open0 (9 samples)
- 0.52% java.io.FileOutputStream.writeBytes (8 samples)
- 0.52% java.lang.StringCoding$StringEncoder.encode (8 samples)
⚠️ Coverage report not generated.

Static Analysis

✅ SpotBugs: no findings (report was not generated by the build).
⚠️ PMD report not generated.
⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

github-actions · 2025-12-18T19:19:35Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2276 total, 0 failed, 0 skipped
📊 Line coverage: 52.95% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.processing.TextEvaluator – 3.45%
  - com.codename1.charts.views.PieChart – 4.00%
  - com.codename1.charts.views.PieMapper – 4.88%
  - com.codename1.charts.views.ScatterChart – 5.32%
  - com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
  - com.codename1.ui.Display$EdtException – 5.56%
  - com.codename1.testing.AbstractTest – 6.05%
  - com.codename1.ui.Transform$ImmutableTransform – 6.06%
  - com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

❌ SpotBugs: 992 findings (High: 90, Normal: 484, Low: 418) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - …and 987 more
❌ PMD: 2728 findings (P2: 1, P3: 650, P4: 2077) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8443 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2723 more
❌ Checkstyle: 219752 findings (Warning: 219752) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 219747 more

Generated automatically by the PR CI workflow.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-12-18T19:22:30Z

vm/ByteCodeTranslator/src/com/codename1/tools/translator/MethodDependencyGraph.java

+public class MethodDependencyGraph {
+    private final Map<String, Set<BytecodeMethod>> callersByLookupSignature = new HashMap<String, Set<BytecodeMethod>>();
+    private final Map<BytecodeMethod, Set<String>> methodToCalls = new HashMap<BytecodeMethod, Set<String>>();
+    private final Map<String, Set<BytecodeMethod>> methodsByClass = new HashMap<String, Set<BytecodeMethod>>();


Keep dependency graph keys class-qualified

MethodDependencyGraph stores caller edges in a HashMap keyed by BytecodeMethod (MethodDependencyGraph.java:40), but BytecodeMethod.equals/hashCode (BytecodeMethod.java:981‑1023) purposely ignore the declaring class. Two methods in different classes with the same name/descriptor therefore collapse to the same key: the second registration overwrites the first, and removeMethod/removeClass will strip call edges for both. When getCallers() is then used to drive elimination, live methods can be treated as unused because their remaining callers were dropped. The graph needs class-qualified keys or identity-based keys to keep per-class methods distinct.

Useful? React with 👍 / 👎.

shai-almog · 2025-12-18T20:18:45Z

iOS screenshot updates

Compared 30 screenshots: 24 matched, 5 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 319 seconds
Compilation Time: 65 seconds

Fix BytecodeMethod equality null safety

f82eacf

shai-almog added the codex label Dec 18, 2025 — with ChatGPT Codex Connector

chatgpt-codex-connector bot reviewed Dec 18, 2025

View reviewed changes

Use identity keys in dependency graph

19b3d3a

shai-almog merged commit d33315b into master Dec 19, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize BytecodeMethod registration and equality #4307

Stabilize BytecodeMethod registration and equality #4307

Uh oh!

shai-almog commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 18, 2025 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Dec 18, 2025

Uh oh!

shai-almog commented Dec 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Stabilize BytecodeMethod registration and equality #4307

Stabilize BytecodeMethod registration and equality #4307

Uh oh!

Conversation

shai-almog commented Dec 18, 2025

Summary

Testing

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ ByteCodeTranslator Quality Report

Test & Coverage

Benchmark Results

Static Analysis

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

shai-almog commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

shai-almog commented Dec 18, 2025 •

edited

Loading