Fix SpotBugs null pointer dereference warnings #4322

google-labs-jules · 2025-12-20T17:28:07Z

This PR fixes 12 potential NullPointerExceptions identified by SpotBugs analysis. The fixes involve adding defensive null checks, initializing variables in default switch cases, and correcting control flow logic in exception helpers. These changes improve the stability and robustness of the codebase against null references.

PR created automatically by Jules for task 104506604435540181 started by @shai-almog

Addressed 12 SpotBugs "Possible null pointer dereference" warnings across 8 files: - CodenameOneImplementation.java: Fixed null usage in captureAudio logging and data check. - InteractionDialog.java: Added null check for rect. - SimpleDateFormat.java: Added return statements to throwInvalid calls. - HashtableContent.java: Added null check for node. - Form.java: Added null checks for components in layered pane iteration. - DefaultLookAndFeel.java: Added null checks for badgeStyle. - SpinnerNode.java: Added null check for selectionListeners before calling isEmpty(). - CommonTransitions.java: Added default case to switch statement.

google-labs-jules · 2025-12-20T17:28:08Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

github-actions · 2025-12-20T17:34:02Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2276 total, 0 failed, 0 skipped
📊 Line coverage: 52.92% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.processing.TextEvaluator – 3.45%
  - com.codename1.charts.views.PieChart – 4.00%
  - com.codename1.charts.views.PieMapper – 4.88%
  - com.codename1.charts.views.ScatterChart – 5.32%
  - com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
  - com.codename1.ui.Display$EdtException – 5.56%
  - com.codename1.testing.AbstractTest – 6.05%
  - com.codename1.ui.Transform$ImmutableTransform – 6.06%
  - com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

❌ SpotBugs: 788 findings (High: 61, Normal: 451, Low: 276) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
  - High: CodenameOne/src/com/codename1/components/ImageViewer.java:310 – Condition has no effect (rule: UC_USELESS_CONDITION)
  - High: CodenameOne/src/com/codename1/components/ToastBar.java:1021 – Potentially ambiguous invocation of either an inherited or outer method (rule: IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)
  - High: CodenameOne/src/com/codename1/facebook/FaceBookAccess.java:191 – Reliance on default encoding (rule: DM_DEFAULT_ENCODING)
  - …and 783 more
❌ PMD: 2712 findings (P2: 1, P3: 633, P4: 2078) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8445 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2707 more
❌ Checkstyle: 219901 findings (Warning: 219901) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 219896 more

Generated automatically by the PR CI workflow.

shai-almog · 2025-12-20T17:41:23Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.63% (2627/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.17% (12164/50336), branch 15.13% (702/4640), complexity 17.30% (730/4220), method 32.40% (588/1815), class 33.99% (103/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.63% (2627/10667 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.17% (12164/50336), branch 15.13% (702/4640), complexity 17.30% (730/4220), method 32.40% (588/1815), class 33.99% (103/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidDB – 0.00% (0/57 lines covered)

shai-almog · 2025-12-20T17:53:14Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 257 seconds
Compilation Time: 62 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	23222 ms
Extract Extensions	15 ms
Google Services Setup	2 ms
Scan Classes	437 ms
Extract Libs	799 ms
Inject Build Hints	31 ms
Generate Unit Tests	2 ms
Generate Stubs	840 ms
Compile Stubs	1948 ms
Generate Icons	778 ms
Prepare ParparVM	127 ms
ParparVM Execution	149770 ms
Post-VM Setup	111 ms
CocoaPods	4000 ms
Finalize	23 ms
Total Time	182105 msMaven Overhead : 75000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	38000 ms
App Install	27000 ms
App Launch	5000 ms
Test Execution	138000 ms

Addressed 12 SpotBugs "Possible null pointer dereference" warnings across 8 files: - CodenameOneImplementation.java: Fixed null usage in captureAudio logging and data check. - InteractionDialog.java: Added explicit null checks for Component and Rectangle arguments in showPopupDialog. - SimpleDateFormat.java: Added return statements to throwInvalid calls. - HashtableContent.java: Added null check for node. - Form.java: Added null checks for components in layered pane iteration and safely handled null Class argument in getLayeredPane. - DefaultLookAndFeel.java: Added null checks for badgeStyle. - SpinnerNode.java: Added null check for selectionListeners before calling isEmpty(). - CommonTransitions.java: Added default case to switch statement.

shai-almog marked this pull request as ready for review December 20, 2025 18:25

shai-almog merged commit c113e8a into master Dec 20, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SpotBugs null pointer dereference warnings #4322

Fix SpotBugs null pointer dereference warnings #4322

Uh oh!

google-labs-jules bot commented Dec 20, 2025

Uh oh!

google-labs-jules bot commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

shai-almog commented Dec 20, 2025 •

edited

Loading

Uh oh!

shai-almog commented Dec 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix SpotBugs null pointer dereference warnings #4322

Fix SpotBugs null pointer dereference warnings #4322

Uh oh!

Conversation

google-labs-jules bot commented Dec 20, 2025

Uh oh!

google-labs-jules bot commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 20, 2025 •

edited

Loading

shai-almog commented Dec 20, 2025 •

edited

Loading

shai-almog commented Dec 20, 2025 •

edited

Loading