Optimize PR CI with custom Docker image #4323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Added `.ci/container/Dockerfile` to pre-install JDKs (8, 17, 21) and cache `cn1-binaries`. - Added `.github/workflows/build-container.yml` to build and push the image to GHCR, ensuring the repository name is lowercased for valid Docker tags. - Updated `.github/workflows/pr.yml` to run inside the new container, replacing `setup-java` with fast environment switching and linking pre-downloaded binaries. - Fixed an issue where mixed-case repository names caused Docker build failures by enforcing lowercase tags in `build-container.yml` and using the canonical image name in `pr.yml`.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a custom Docker image for the PR CI workflow to significantly speed up build times by pre-installing expected Java versions (8, 17, 21) and caching large dependencies like
cn1-binaries.Changes:
.ci/container/Dockerfile: Defines the image with Ubuntu 24.04, JDKs (ZuluFX 8, OpenJDK 17/21), andcn1-binaries..github/workflows/build-container.yml: Workflow to build and push the image to GHCR..github/workflows/pr.yml:actions/setup-javawith fast environment switching for pre-installed JDKs.cn1-binariesinstead of downloading them during the run.packages: readpermission to pull the container.PR created automatically by Jules for task 10047781061034201389 started by @shai-almog