Integrate Docker container into PR workflow #4325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the PR CI workflow to run inside the `pr-ci-container` image.
- Add `packages: read` permission.
- Set `container: ghcr.io/codenameone/codenameone/pr-ci-container:latest`.
- Use container environment variables (`JAVA{v}_HOME`) to configure Java versions instead of `actions/setup-java`.
- Remove redundant dependency installations (`apt-get`, `wget`) and use pre-installed binaries from `/opt/cn1-binaries`.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Switch the PR CI workflow to run inside the `pr-ci-container` image. - Add `packages: read` permission. - Set `container: ghcr.io/codenameone/codenameone/pr-ci-container:latest`. - Configure `JAVA_HOME` using container environment variables (`JAVA_HOME_8`, `JAVA_HOME_17`, `JAVA_HOME_21`) instead of `actions/setup-java`. - Remove redundant dependency installations (`apt-get`, `wget`) and use pre-installed binaries from `/opt/cn1-binaries`. - Remove Java 25 from the build matrix as it is not supported in the container.
…kflow 1. Replaced non-ASCII '→' character with '->' in `AndroidScreenshotTask.java` to fix `javac` "unmappable character" errors in ASCII-only environments. 2. Migrated `.github/workflows/pr.yml` to run inside the `pr-ci-container` Docker image: - Added `packages: read` permission. - Configured `JAVA_HOME` using container environment variables (`JAVA_HOME_8`, etc.) instead of `actions/setup-java`. - Replaced redundant dependency downloads with local symlinks/copies from `/opt/cn1-binaries`. - Removed Java 25 from the build matrix as it's not supported in the container.
Collaborator
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
.github/workflows/pr.ymlto utilize thepr-ci-containerDocker image. This involved removing manual setup steps for Java and system dependencies, relying instead on the pre-configured environment and environment variables within the container. Specifically,actions/setup-javawas replaced with logic settingJAVA_HOMEfrom container env vars, and the manual download ofcn1-binarieswas replaced with a symlink to/opt/cn1-binaries.PR created automatically by Jules for task 14983396566325065724 started by @shai-almog