Skip to content

Fix BrowserTest screenshot timing issue #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shai-almog merged 1 commit into from
Dec 22, 2025
Merged

Fix BrowserTest screenshot timing issue #4329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions .../java/com/codenameone/examples/hellocodenameone/tests/BrowserComponentScreenshotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@
import com.codename1.ui.Form;
import com.codename1.ui.layouts.BorderLayout;
import com.codename1.ui.util.UITimer;
import com.codename1.util.SuccessCallback;

public class BrowserComponentScreenshotTest extends BaseTest {
private BrowserComponent browser;
private boolean loaded;
private Runnable readyRunnable;
private Form form;
private boolean jsReady;
private boolean jsCheckPending;

@Override
public boolean runTest() throws Exception {
Expand All @@ -36,10 +39,25 @@ protected void registerReadyCallback(Form parent, final Runnable run) {
}

private void checkReady() {
if (loaded && readyRunnable != null) {
UITimer.timer(500, false, form, readyRunnable);
readyRunnable = null;
if (!loaded || readyRunnable == null) {
return;
}
if (!jsReady) {
if (!jsCheckPending) {
jsCheckPending = true;
// Verify content is actually present in the DOM
browser.execute("callback.onSuccess(document.body.innerText)", new SuccessCallback<BrowserComponent.JSRef>() {
public void onSucess(BrowserComponent.JSRef result) {
jsReady = true;
checkReady();
}
});
}
return;
}

UITimer.timer(2000, false, form, readyRunnable);
readyRunnable = null;
}

private static String buildHtml() {
Expand Down
Loading