Fix drag jitter caused by stale coordinates in asynchronous drag callbacks #4333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ordinates The existing logic in Component.pointerDragged scheduled a callSerially runnable to ensure drag events continue (e.g. for auto-scrolling) even if the pointer is stationary. However, it captured the `x` and `y` arguments from the method call. If multiple drag events occurred rapidly, these scheduled tasks would execute out of order relative to the latest system events, calling pointerDragged with stale coordinates. This caused the drag position to "jump back" to a previous location, resulting in visual jitter and incorrect drag direction detection. This fix updates the runnable to use `oldx` and `oldy` (instance fields tracking the latest processed drag position) instead of the captured arguments. This ensures that when the delayed task executes, it uses the most up-to-date position, effectively preventing the replay of stale coordinates.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where drag events would arrive out of order or duplicate with stale coordinates due to
callSeriallycapturing local variables. Updated the logic to use instance fieldsoldxandoldyto ensure asynchronous drag updates always use the latest known position.PR created automatically by Jules for task 2254117794441463981 started by @shai-almog