Fix HTML email sending on Android by adding EXTRA_HTML_TEXT #4346
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `android.intent.extra.HTML_TEXT` to the email intent when sending HTML messages. This ensures modern email clients (like Gmail) render the HTML content correctly instead of stripping it or displaying plain text.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
Collaborator
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user reported that sending HTML emails on Android stopped working around API level 24. This was due to changes in how
Intent.EXTRA_TEXTis handled and potentially stricter requirements for HTML content in intents.This change adds the
android.intent.extra.HTML_TEXTextra to the intent when the mime type istext/html. This is the standard way to provide HTML content for email intents on Android (API 16+), and serves as the primary content source for compliant email clients, withEXTRA_TEXT(populated viaHtml.fromHtml) remaining as a fallback.The fix is implemented in
Ports/Android/src/com/codename1/impl/android/AndroidImplementation.javawithin thesendMessagemethod. The change is backward compatible as older clients will simply ignore the unknown extra.PR created automatically by Jules for task 13254237403348100486 started by @shai-almog