Fix SpotBugs SA_FIELD_SELF_ASSIGNMENT warnings #4365

google-labs-jules · 2025-12-26T13:26:44Z

Fixes SpotBugs "Self assignment of field" warnings in CodenameOne/src/com/codename1/io/gzip/InfBlocks.java and CodenameOne/src/com/codename1/io/gzip/Inflate.java by adding conditional checks before assignment.
Also updates .github/scripts/generate-quality-report.py to enforce this rule in the quality report.

PR created automatically by Jules for task 2397598729012057962 started by @shai-almog

- Fix self-assignments in `InfBlocks.java` and `Inflate.java`. - Update `.github/scripts/generate-quality-report.py` to fail on `SA_FIELD_SELF_ASSIGNMENT`.

google-labs-jules · 2025-12-26T13:26:45Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

shai-almog · 2025-12-26T13:39:43Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.73% (2649/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.37% (12306/50505), branch 15.32% (715/4668), complexity 17.47% (740/4237), method 32.84% (597/1818), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.73% (2649/10711 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.37% (12306/50505), branch 15.32% (715/4668), complexity 17.47% (740/4237), method 32.84% (597/1818), class 34.98% (106/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

shai-almog · 2025-12-26T13:52:53Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 265 seconds
Compilation Time: 54 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	23846 ms
Extract Extensions	15 ms
Google Services Setup	2 ms
Scan Classes	627 ms
Extract Libs	986 ms
Inject Build Hints	32 ms
Generate Unit Tests	5 ms
Generate Stubs	799 ms
Compile Stubs	2024 ms
Generate Icons	755 ms
Prepare ParparVM	122 ms
ParparVM Execution	157608 ms
Post-VM Setup	141 ms
CocoaPods	4496 ms
Finalize	24 ms
Total Time	191483 msMaven Overhead : 74000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot (Run)	46000 ms
App Install	22000 ms
App Launch	9000 ms
Test Execution	136000 ms

- Removed redundant self-assignments in `InfBlocks.java` when restoring state in `case TYPE` and `case DRY`. - Removed redundant `this.marker = m` assignment in `Inflate.java`. - Updated `.github/scripts/generate-quality-report.py` to enforce `SA_FIELD_SELF_ASSIGNMENT` check.

- Removed redundant self-assignments in `InfBlocks.java` when restoring state in `case TYPE` and `case DRY`. - Replaced redundant `this.marker = m` assignment in `Inflate.java` with a conditional check to ensure state updates are preserved if `m` changes. - Updated `.github/scripts/generate-quality-report.py` to enforce `SA_FIELD_SELF_ASSIGNMENT` check.

- Removed redundant self-assignments in `InfBlocks.java` when restoring state in `case TYPE` and `case DRY`. - Corrected `Inflate.java` to use a conditional assignment for `this.marker` to ensure state is preserved if it changes, while satisfying SpotBugs. - Updated `.github/scripts/generate-quality-report.py` to enforce `SA_FIELD_SELF_ASSIGNMENT` check.

- Removed redundant self-assignments in `InfBlocks.java` when restoring state in `case TYPE` and `case DRY`. - Refactored `Inflate.java` to use `this.marker` directly instead of a local variable `m`, eliminating the redundant self-assignment while preserving logic. - Updated `.github/scripts/generate-quality-report.py` to enforce `SA_FIELD_SELF_ASSIGNMENT` check.

…tions - Reverted changes to `InfBlocks.java` and excluded it from the `SA_FIELD_SELF_ASSIGNMENT` check in `.github/scripts/generate-quality-report.py`. - Refactored `Inflate.java` to eliminate `this.marker = m` self-assignment by using `this.marker` directly. - Updated `.github/scripts/generate-quality-report.py` to add `SA_FIELD_SELF_ASSIGNMENT` to forbidden rules.

github-actions · 2025-12-26T19:30:59Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2281 total, 0 failed, 0 skipped
📊 Line coverage: 52.89% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.processing.TextEvaluator – 3.85%
  - com.codename1.charts.views.PieChart – 4.00%
  - com.codename1.charts.views.PieMapper – 4.88%
  - com.codename1.charts.views.ScatterChart – 5.32%
  - com.codename1.ui.list.GenericListCellRenderer$Monitor – 5.33%
  - com.codename1.ui.Display$EdtException – 5.56%
  - com.codename1.testing.AbstractTest – 6.05%
  - com.codename1.ui.Transform$ImmutableTransform – 6.06%
  - com.codename1.charts.views.DoughnutChart – 6.25%

Static Analysis

❌ SpotBugs: 519 findings (High: 7, Normal: 321, Low: 191) [HTML preview] [Download]
- Top findings
  - High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
  - High: CodenameOne/src/com/codename1/io/NetworkManager.java:1064 – equals method always returns false (rule: EQ_ALWAYS_FALSE)
  - High: CodenameOne/src/com/codename1/io/gzip/InfBlocks.java:153 – Self assignment of field (rule: SA_FIELD_SELF_ASSIGNMENT)
  - High: CodenameOne/src/com/codename1/io/gzip/InfBlocks.java:154 – Self assignment of field (rule: SA_FIELD_SELF_ASSIGNMENT)
  - High: CodenameOne/src/com/codename1/io/gzip/InfBlocks.java:158 – Self assignment of field (rule: SA_FIELD_SELF_ASSIGNMENT)
  - …and 514 more
❌ PMD: 2727 findings (P2: 1, P3: 633, P4: 2093) [HTML preview] [Download]
- Top findings
  - P2: CodenameOne/src/com/codename1/ui/Display.java:1022 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
  - P3: CodenameOne/src/com/codename1/charts/views/LineChart.java:208 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
  - P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8470 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
  - …and 2722 more
❌ Checkstyle: 220262 findings (Warning: 220262) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 220257 more

Generated automatically by the PR CI workflow.

Fix SpotBugs SA_FIELD_SELF_ASSIGNMENT warnings in gzip package

34f9b25

- Fix self-assignments in `InfBlocks.java` and `Inflate.java`. - Update `.github/scripts/generate-quality-report.py` to fail on `SA_FIELD_SELF_ASSIGNMENT`.

google-labs-jules bot added 6 commits December 26, 2025 13:55

shai-almog marked this pull request as ready for review December 26, 2025 19:58

shai-almog merged commit 365b110 into master Dec 26, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SpotBugs SA_FIELD_SELF_ASSIGNMENT warnings #4365

Fix SpotBugs SA_FIELD_SELF_ASSIGNMENT warnings #4365

google-labs-jules bot commented Dec 26, 2025

Uh oh!

google-labs-jules bot commented Dec 26, 2025

Uh oh!

shai-almog commented Dec 26, 2025 •

edited

Loading

Uh oh!

shai-almog commented Dec 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix SpotBugs SA_FIELD_SELF_ASSIGNMENT warnings #4365

Fix SpotBugs SA_FIELD_SELF_ASSIGNMENT warnings #4365

Conversation

google-labs-jules bot commented Dec 26, 2025

Uh oh!

google-labs-jules bot commented Dec 26, 2025

Uh oh!

shai-almog commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Dec 26, 2025

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Dec 26, 2025 •

edited

Loading

shai-almog commented Dec 26, 2025 •

edited

Loading